Skip to content

Conversation

@rich7420
Copy link
Contributor

Purpose of PR

This PR is third part of test_single_qubit_gates.py.
This file is split into 3 cumulative PRs including those tests:

TestPauliXGate
TestPauliYGate
TestPauliZGate
TestPauliZGate.test_pauli_z_with_hadamard
TestHadamardGate
TestNOTGate
TestUGate
TestSingleQubitGatesEdgeCases
TestSingleQubitGatesConsistency

This PR is about tests of them: TestSingleQubitGatesEdgeCases and TestSingleQubitGatesConsistency.

You can test this PR locally with command:

pytest testing/test_single_qubit_gates.py

Related Issues or PRs

#604

Changes Made

  • Bug fix
  • New feature
  • Refactoring
  • Documentation
  • Test
  • CI/CD pipeline
  • Other

Breaking Changes

  • Yes
  • No

Checklist

  • Added or updated unit tests for all changes
  • Added or updated documentation for all changes
  • Successfully built and ran all unit tests or manual tests locally
  • PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
  • Code follows ASF guidelines

Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I think let's just keep important comments here current amount seems too much

@guan404ming
Copy link
Member

Need to fix lint and pre-commit error, thanks!

@rich7420
Copy link
Contributor Author

@guan404ming thanks for the review! I'll modify it as soon as possible.

@rich7420
Copy link
Contributor Author

@guan404ming I've followed your suggestions.

@guan404ming guan404ming merged commit 8cb06c4 into apache:main Nov 12, 2025
4 checks passed
@guan404ming
Copy link
Member

Thanks!

@rich7420
Copy link
Contributor Author

thanks @guan404ming !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants