-
Notifications
You must be signed in to change notification settings - Fork 973
MAHOUT-613: execute_circuit() error in Amazon Braket backend #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
guan404ming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's add some tests to prevent regression.
|
Small suggestion: we could add |
|
OK @guan404ming , thanks for the reminding! and I'll add a regression test for it. |
|
@guan404ming I've added a test for it. |
guan404ming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's also test other backedn as well here
|
This test failure needs #621 to fix. |
|
@guan404ming I've merged into a PR~ |
guan404ming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, could we try to test this issue in different backend instead of only test one of them to prevent regression?
|
sure , I'd try to write a test for this. |
|
@guan404ming there's a test for all backend. |
|
Please help fix the ci error, thanks! |
|
@guan404ming sure! already updated. |
|
Thanks! |
Purpose of PR
to fix execute_circuit() error in Amazon Braket backend.
Related Issues or PRs
Closes #613
Closes #621
Changes Made
Breaking Changes
Checklist