Skip to content

Conversation

@rich7420
Copy link
Contributor

@rich7420 rich7420 commented Nov 12, 2025

Purpose of PR

to fix execute_circuit() error in Amazon Braket backend.

Related Issues or PRs

Closes #613
Closes #621

Changes Made

  • Bug fix
  • New feature
  • Refactoring
  • Documentation
  • Test
  • CI/CD pipeline
  • Other

Breaking Changes

  • Yes
  • No

Checklist

  • Added or updated unit tests for all changes
  • Added or updated documentation for all changes
  • Successfully built and ran all unit tests or manual tests locally
  • PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
  • Code follows ASF guidelines

Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's add some tests to prevent regression.

@guan404ming
Copy link
Member

guan404ming commented Nov 12, 2025

Small suggestion: we could add close #000 in PR body, which would automatically link the issue to this PR and would close the issue once the PR merged.

@rich7420
Copy link
Contributor Author

OK @guan404ming , thanks for the reminding! and I'll add a regression test for it.

@rich7420
Copy link
Contributor Author

@guan404ming I've added a test for it.

Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's also test other backedn as well here

@rich7420
Copy link
Contributor Author

This test failure needs #621 to fix.

@rich7420
Copy link
Contributor Author

@guan404ming I've merged into a PR~

Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, could we try to test this issue in different backend instead of only test one of them to prevent regression?

@rich7420
Copy link
Contributor Author

sure , I'd try to write a test for this.

@rich7420
Copy link
Contributor Author

@guan404ming there's a test for all backend.

@guan404ming
Copy link
Member

Please help fix the ci error, thanks!

@rich7420
Copy link
Contributor Author

@guan404ming sure! already updated.

@guan404ming guan404ming merged commit 858af4a into apache:main Nov 14, 2025
4 checks passed
@rich7420
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Error message in execute_circuit() is not clear [Bug] execute_circuit() error in Amazon Braket backend

2 participants