-
Notifications
You must be signed in to change notification settings - Fork 973
MAHOUT-625: Add more cases in test_single_qubit_gates.py #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
guan404ming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, one nit.
|
@guan404ming I've updated. thanks for the suggestion! |
guan404ming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, please help fix the ci error.
|
Thanks @guan404ming ,Already fixed format error. And Python Testing failed is correct because #623 hasn't be solved. |
|
Sure, let's wait for the fix or do you want to help with that? |
|
I think you could directly integrate the fix into this PR if you want, thanks! |
|
No problem! |
|
@guan404ming I've fixed the error. |
guan404ming
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Purpose of PR
To cover more comprehensively, This PR adds more cases in test_single_qubit_gates.py.
Related Issues or PRs
Closes #625
Closes #623
Changes Made
Breaking Changes
Checklist