Skip to content

Conversation

@rich7420
Copy link
Contributor

@rich7420 rich7420 commented Nov 13, 2025

Purpose of PR

To cover more comprehensively, This PR adds more cases in test_single_qubit_gates.py.

Related Issues or PRs

Closes #625
Closes #623

Changes Made

  • Bug fix
  • New feature
  • Refactoring
  • Documentation
  • Test
  • CI/CD pipeline
  • Other

Breaking Changes

  • Yes
  • No

Checklist

  • Added or updated unit tests for all changes
  • Added or updated documentation for all changes
  • Successfully built and ran all unit tests or manual tests locally
  • PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
  • Code follows ASF guidelines

Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, one nit.

@rich7420
Copy link
Contributor Author

@guan404ming I've updated. thanks for the suggestion!

Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, please help fix the ci error.

@rich7420
Copy link
Contributor Author

rich7420 commented Nov 14, 2025

Thanks @guan404ming ,Already fixed format error. And Python Testing failed is correct because #623 hasn't be solved.

@guan404ming
Copy link
Member

Sure, let's wait for the fix or do you want to help with that?

@guan404ming
Copy link
Member

I think you could directly integrate the fix into this PR if you want, thanks!

@rich7420
Copy link
Contributor Author

No problem!

@rich7420
Copy link
Contributor Author

@guan404ming I've fixed the error.

Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@guan404ming guan404ming merged commit 85f0af3 into apache:main Nov 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Add more cases in test_single_qubit_gates.py [Bug] Incorrect U-gate decomposition in Cirq and Amazon Braket backends.

2 participants