Skip to content

Conversation

@CheyuWu
Copy link

@CheyuWu CheyuWu commented Dec 27, 2025

Purpose of PR

This issue asks the ability to detect and handle PyTorch tensors, focusing on cpu tensors.

  1. add PyTorch tensor detection utilities
  2. add tensor validation
  3. add cpu tensor path in encode_tensor()
  4. add error handling
  5. add basic tests

Related Issues or PRs

Closes #725

Changes Made

  • Bug fix
  • New feature
  • Refactoring
  • Documentation
  • Test
  • CI/CD pipeline
  • Other

Breaking Changes

  • Yes
  • No

Checklist

  • Added or updated unit tests for all changes
  • Added or updated documentation for all changes
  • Successfully built and ran all unit tests or manual tests locally
  • PR title follows "MAHOUT-XXX: Brief Description" format (if related to an issue)
  • Code follows ASF guidelines

@CheyuWu CheyuWu changed the title [QDP] PyTorch Tensor Detection and CPU Path MAHOUT-725 [QDP] PyTorch Tensor Detection and CPU Path Dec 27, 2025
@CheyuWu CheyuWu changed the title MAHOUT-725 [QDP] PyTorch Tensor Detection and CPU Path MAHOUT-725: [QDP] PyTorch Tensor Detection and CPU Path Dec 27, 2025
@CheyuWu CheyuWu changed the base branch from main to dev-qdp December 27, 2025 14:07
@CheyuWu
Copy link
Author

CheyuWu commented Dec 27, 2025

Manual Testing

(mahout) user@DESKTOP-UDTSV2K:~/code/mahout$ cd ./qdp/qdp-python/
(mahout) user@DESKTOP-UDTSV2K:~/code/mahout/qdp/qdp-python$ cp ../target/debug/libmahout_qdp.so mahout_qdp.so && PYTHONPATH=. pytest .
========================================================================== test session starts ==========================================================================
platform linux -- Python 3.11.13, pytest-9.0.2, pluggy-1.6.0
rootdir: /home/user/code/mahout/qdp/qdp-python
configfile: pyproject.toml
collected 21 items                                                                                                                                                      

tests/test_bindings.py ...s.....                                                                                                                                  [ 42%]
tests/test_high_fidelity.py ............                                                                                                                          [100%]

===================================================================== 20 passed, 1 skipped in 3.30s =====================================================================

@rich7420 rich7420 added the qdp label Dec 29, 2025
@github-project-automation github-project-automation bot moved this to Backlog in QDP Dec 29, 2025
@400Ping
Copy link

400Ping commented Dec 29, 2025

please fix the ci error

@CheyuWu
Copy link
Author

CheyuWu commented Dec 29, 2025

Hi @400Ping, I have fixed the problem PTAL

@400Ping
Copy link

400Ping commented Dec 29, 2025

I think overall is good but we are going to merge #753 into dev-qdp, I think it is best to wait for it to merge and fix the conflicts for this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

[QDP] PyTorch Tensor Detection and CPU Path

3 participants