Skip to content

Improved: Replace all non 'alnum'/non 'punct' chars by spaces in numeric fields #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Improved: Replace all non 'alnum'/non 'punct' chars by spaces in numeric fields #849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions framework/base/src/main/java/org/apache/ofbiz/base/util/ObjectType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,13 +331,10 @@ public static Object simpleTypeOrObjectConvert(Object obj, String type, String f
}

if (converter != null) {
// numeric types : replace non-breaking spaces (which break parsing) by normal spaces
// numeric types : replace everything that's not in [:alumn:] or [:punct:] classes by regular spaces
List<?> numericClasses = UtilMisc.toList(BigDecimal.class, Double.class, Float.class);
if (obj instanceof String && numericClasses.contains(targetClass)) {
final String[] tmp = {String.valueOf(obj)};
List<Character> nonBreakingWhitespaces = UtilMisc.toList('\u00A0', '\u202F', '\u2007');
nonBreakingWhitespaces.forEach(character -> tmp[0] = tmp[0].replace(character, ' '));
obj = tmp[0];
obj = ((String) obj).replaceAll("[^\\p{Alnum}\\p{Punct}]", " ");
}

if (converter instanceof LocalizedConverter) {
Expand Down
2 changes: 1 addition & 1 deletion framework/base/src/test/java/org/apache/ofbiz/base/util/ObjectTypeTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ public void testArray() throws GeneralException {
}

@Test
public void testString() throws GeneralException, Exception {
public void testString() throws GeneralException {
simpleTypeOrObjectConvertTest("String->String", "one", "String", "one");
simpleTypeOrObjectConvertTest("String->String", "one", "java.lang.String", "one");
simpleTypeOrObjectConvertTestSingleMulti("empty-String->anything", "", new String[] {"List", "Map"}, null);
Expand Down