Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/nightly-builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ jobs:
# binary version is required and Pekko build will set the right
# full version from it.
scalaVersion: ["2.13.x", "3.3.x"]
javaVersion: [17, 21]
javaVersion: [17, 21, 25]
env:
DEVELOCITY_ACCESS_KEY: ${{ secrets.DEVELOCITY_ACCESS_KEY }}
steps:
Expand Down Expand Up @@ -160,8 +160,7 @@ jobs:
clean "++ ${{ matrix.scalaVersion }} test" checkTestsHaveRun

- name: Docs
# Docs generation requires JDK 11.
if: ${{ matrix.javaVersion == 11 }}
Comment on lines -163 to -164
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs build ok with Java 17 now - after Paradox fixes

if: ${{ matrix.javaVersion == 17 }}
run: |-
sudo apt-get install graphviz
# genjavadoc does not support Scala 3.x
Expand All @@ -170,8 +169,7 @@ jobs:
"++ ${{ matrix.scalaVersion }} doc"

- name: Publish
# Publish (osgi bundle) not working with JDK 17, issue #31132
if: ${{ matrix.javaVersion == 11 }}
if: ${{ matrix.javaVersion == 17 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this was fixed? I guess we'll see :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this fails, we'll have to fix it or drop this testing altogether - it is effectively disabled prior to this change because Java 17 is the min version used in the build

run: |-
sudo apt-get install graphviz
sbt \
Expand Down