PHOENIX-7524: Fix IndexOutOfBoundsException in queries with OFFSET when rows are exhausted #2307
+220
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en rows are exhausted
Contributor
Contributor
Author
TheNamesRai
commented
Oct 28, 2025
| * @param region The region being scanned | ||
| * @return A valid row key derived from scan or region boundaries | ||
| */ | ||
| public static byte[] deriveRowKeyFromScanOrRegionBoundaries(Scan scan, Region region) { |
Contributor
Author
There was a problem hiding this comment.
Naming convention for this method is similar to getScanStartRowKeyFromScanOrRegionBoundaries method in the ServerUtil.java
Contributor
There was a problem hiding this comment.
Can we use getScanStartRowKeyFromScanOrRegionBoundaries() instead of this new method?
virajjasani
reviewed
Nov 26, 2025
Comment on lines
+314
to
+315
| } else if (scan.includeStopRow()) { | ||
| rowKey = endKey; |
Contributor
There was a problem hiding this comment.
I wonder if this generates correct rowkey: if scan start rowkey is not inclusive, we need to find the shortest possible next rowkey?
I think we should have this logic elsewhere, @TheNamesRai could you please check once?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHOENIX-7524: Fix
IndexOutOfBoundsExceptionin queries with OFFSET when rows are exhaustedDesign doc - link
When executing queries with OFFSET where the available rows are exhausted:
The server-side scanner would encounter an empty tuple after exhausting all available rows and attempt to call
getOffsetKvWithLastScannedRowKey(), which internally calls tuple.getKey(). This causedIndexOutOfBoundsExceptioninMultiKeyValueTuple.getKey()when accessing an empty tuple.Solution - Added a check in NonAggregateRegionScannerFactory.java to detect empty tuples before calling
getOffsetKvWithLastScannedRowKey()Modified Files:
Test Files: