PHOENIX-7719 Prewarm HAGroupStore Client #2313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadirozde
requested changes
Nov 14, 2025
| return; | ||
| } | ||
|
|
||
| List<String> pending = new ArrayList<>(manager.getHAGroupNames()); |
Contributor
There was a problem hiding this comment.
If the HA table region is not ready, manager.getHAGroupNames() would return an exception. We should catch the exception and retry.
Contributor
Author
There was a problem hiding this comment.
Updated the prewarm method to handle this condition. Also updated the javadoc
kadirozde
reviewed
Nov 14, 2025
| LOGGER.debug("HAGroupStoreManager is null, retrying in 2s..."); | ||
| } | ||
|
|
||
| if (pending == null) { |
Contributor
There was a problem hiding this comment.
This should not be necessary, pending cannot be null here. manager.getHAGroupNames() either returns a list possibly empty or an exception, right?
Contributor
Author
There was a problem hiding this comment.
Removed, it also handled case when manager is null, added that explicitly now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently HAGroupStoreClient is lazily initialized for a given haGroupName. When first mutation comes in, the HAGroupStoreClient for that haGroupName is invoked. This can cause blocking delay for the first call while HAGroupStoreClient initializes.
This task is to initialize the HAGroupStoreClient for all the HAGroups in System.HA_Group table asynchronously as part of RegionServerEndpoint's coproc start() method. The async executor should exit when HAGroupStoreClients are initialized. This will reduce the blocking wait time for first call.
Testing
Added a prewarming enabled config with default as true. Enabled config in 1 cluster and disabled in the other. Comparing the times for getting ClusterRoleRecord in both and asserting that prewarmed is better than non-prewarmed.