PHOENIX-7602 Replication Log Writer (Store and Forward mode) #2315
+3,142
−1,567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadirozde
reviewed
Nov 10, 2025
| // Doing the mode check on sync points makes the implementation more robust | ||
| // since we can guarantee that all unsynced appends have been flushed to the | ||
| // replication log before we switch the replication mode | ||
| ReplicationMode newMode = getMode(); |
Contributor
There was a problem hiding this comment.
Mode change should be handled in at the beginning of processPendingSyncs() in order to make sure that it is not delayed indefinitely
kadirozde
reviewed
Nov 10, 2025
| // is not processing any event like append/sync because this is the only thread | ||
| // that is consuming the events from the ring buffer and handing them off to the | ||
| // mode | ||
| currentModeImpl.onExit(true); |
Contributor
There was a problem hiding this comment.
onExit should be done asynchronously so that it does not add additional time in the failure handling.
tkhurana
force-pushed
the
PHOENIX-7602
branch
from
32dc4e2 to
e213985
Compare
added 7 commits
November 19, 2025 12:18
This patch implements the replication mode transitions and log forwarding from fallback cluster to the standby cluster.
tkhurana
force-pushed
the
PHOENIX-7602
branch
from
58da592 to
b941f01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the replication mode transitions and log forwarding from fallback cluster to the standby cluster.