[improve][broker] Add an option to return 0 when querying partitions of a nonexistent topic #18594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of a nonexistent topic ### Motivation apache#10601 (comment) apache#10601 changes the behavior when querying partitions of a topic that is not created. Before apache#10601, 0 is returned. After apache#10601, an exception will be thrown to indicate the topic does not exist. It leads to the incompatibility with some old Pulsar clients that do not add the "checkAllowAutoCreation=true" query param. If they use HTTP service URL like "http://localhost:8080", when accessing a topic that does not exist, the client will fail. The affected Pulsar clients include Java client <= 2.4.2 and C++/Python client <= 2.8.0. ### Modifications Add an option `checkTopicExistsWhenQueryPartitions` (default: true) to determine the behavior. Disable this option to keep the original behavior that 0 will be returned when querying partitions of a nonexistent topic.
BewareMyPower
added
the
type/enhancement
BewareMyPower
requested review from
315157973,
codelipenghui,
coderzc,
eolivelli,
merlimat,
michaeljmarshall and
rdhabalia
Contributor
Author
|
This PR also fixes the incompatibility issue of allowAutoTopicCreationType=partitioned
defaultNumPartitions=4Then producing a message to a topic named "my-topic", you can see the created topic is still non-partitioned. $ ./bin/pulsar-admin topics list public/default
"persistent://public/default/my-topic"However, with the standalone that includes this patch. checkTopicExistsWhenQueryPartitions=false
allowAutoTopicCreationType=partitioned
defaultNumPartitions=4The created topic is a partitioned topic: $ ./bin/pulsar-admin topics list public/default
"persistent://public/default/my-topic-partition-0"
"persistent://public/default/my-topic-partition-3"
"persistent://public/default/my-topic-partition-1"
"persistent://public/default/my-topic-partition-2" |
Contributor
|
@rdhabalia PTAL |
|
The pr had no activity for 30 days, mark with Stale label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#10601 (comment)
#10601 changes the behavior when querying partitions of a topic that is not created. Before #10601, 0 is returned. After #10601, an exception will be thrown to indicate the topic does not exist. It leads to the incompatibility with some old Pulsar clients that do not add the "checkAllowAutoCreation=true" query param. If they use HTTP service URL like "http://localhost:8080", when accessing a topic that does not exist, the client will fail.
The affected Pulsar clients include Java client <= 2.4.2 and C++/Python client <= 2.8.0.
Modifications
Add an option
checkTopicExistsWhenQueryPartitions(default: true) to determine the behavior. Disable this option to keep the original behavior that 0 will be returned when querying partitions of a nonexistent topic.Verifying this change
This change added
HttpPartitionMetadataLookupTestto show the behavior whencheckTopicExistsWhenQueryPartitionsis true or false.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: BewareMyPower#10