Skip to content

Conversation

@AnnaYue
Copy link
Contributor

@AnnaYue AnnaYue commented Jan 9, 2026

What is the purpose of the change

support multi unit in trace config

Brief changelog

When init trace intercepter for multi unit, trace client init with default unit name and instance name, cause generate same clientID for different unit server, but serverUrl resolved with different IPs, lead to client loadOrStore return nil and finally nil pointer crash.
So add UnitName param in traceConfig to allow unit name pass down.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing merged commit 99c4336 into apache:master Jan 12, 2026
7 checks passed
@AnnaYue AnnaYue deleted the support-multi-unit-in-trace branch January 12, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants