Skip to content

Conversation

@Larborator
Copy link
Contributor

@Larborator Larborator commented Nov 18, 2025

Purpose of this pull request

Related PR is #6755. When the transaction is already committed/visible, Doris sink should consider it is a successful load and not throw exception.
On the other hand, Doris V3.0 has updated stream load error messages, so we use COMMITTED_PATTERN.matcher(msg).find() instead of COMMITTED_PATTERN.matcher(msg).matches()

Below is Doris 3.0 load error msg:
1763471295138

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@Larborator
Copy link
Contributor Author

@Hisoka-X Could you help review this PR?

@Larborator
Copy link
Contributor Author

@zhangshenghang Could you help review this PR?

Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Carl-Zhou-CN
Copy link
Member

@Larborator Thank you for your contribution

@corgy-w corgy-w merged commit c3b63c8 into apache:dev Dec 2, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants