[DOC] removed deadlinks from the events/conferences; replaced with videoplay list from early Spark Summits #640
Conversation
…ist recordings from previous spark summits. Signed-off-by: Jules Damji <[email protected]>
dmatrix
changed the title
dmatrix
changed the title
Signed-off-by: Jules Damji <[email protected]>
Signed-off-by: Jules Damji <[email protected]>
Signed-off-by: Jules Damji <[email protected]>
…okay." This reverts commit 9909a48.
…deadlinks_community_page' into br_jsd_remove_more_deadlinks_community_page
Signed-off-by: Jules Damji <[email protected]>
site/index.html
Outdated
| <meta name="twitter:title" content=" Apache Spark™ - Unified Engine for large-scale data analytics"> | ||
| <meta name="twitter:description" content="Apache Spark is a multi-language engine for executing data engineering, data science, and machine learning on single-node machines or clusters."> | ||
| <meta name="twitter:image" content="https://spark.apache.org/images/spark-twitter-card-large.jpg"> | ||
| <meta name="twitter:image" content="http://localhost:4000/images/spark-twitter-card-large.jpg"> |
There was a problem hiding this comment.
These changes are now making the build fail. I'd honestly just manually edit the change at this point to fix all the differences it complains about, rather than debug further. I can't merge this while the PR builder does not pass.
There was a problem hiding this comment.
Blimey. I never touched any of the files it complains about. Well, I'll fix it.
There was a problem hiding this comment.
This build process seems like a slippery slope. I did not touch any of the pages it complains about, yet it reveals a new one after each triggered workflow. Do we keep doing that until it ends, or am I glaringly missing something here?
There was a problem hiding this comment.
What do you reckon we should do if this keeps spewing the next build issue?
There was a problem hiding this comment.
I don't know, I haven't worked on this in a long time. I recall it worked but you had to use the ruby env in this repo and you need to Jekyll build and not serve
It isn't worth more work here unless you feel like debugging. Just get it to match by hand in this case.
There was a problem hiding this comment.
I did change by hand. See the last two committs. So something is off.
Can you lift the suggested changes, approve it, and I'll work with @HyukjinKwon to sort it out since we are cutting a 4.1 preview3 release soon, and it would be nice if it can be merge there.
There was a problem hiding this comment.
I can still see "localhost:4000" in your change. Did you push?
You can see the failing check below and click through to see the issue.
No, the fastest thing here is to just get the changes in your PR here.
There was a problem hiding this comment.
Okay. I removed all references localhost in the actual site/.html files that the build was barfing on, committed and pushed. If the build fails, then I throw my towel in the ring .. ... lol
Signed-off-by: Jules Damji <[email protected]>
Signed-off-by: Jules Damji <[email protected]>
Signed-off-by: Jules Damji <[email protected]>
Signed-off-by: Jules Damji <[email protected]>
There was a problem hiding this comment.
@HyukjinKwon can you merge? My local setup is not working anymore
|
Merged to asf-site. |
3 participants
Uh oh!
There was an error while loading. Please reload this page.