[DO-NOT-MERGE] Prototype: runtime profiling of Python workers #52679
+373
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
force-pushed
the
yappi-prototype
branch
from
6b9e9ae to
39fb9dc
Compare
holdenk
reviewed
Oct 31, 2025
| } | ||
| // allow the user to set the batch size for the BatchedSerializer on UDFs | ||
| envVars.put("PYTHON_UDF_BATCH_SIZE", batchSizeForPythonUDF.toString) | ||
| envVars.put("PYSPARK_RUNTIME_PROFILE", true.toString) |
There was a problem hiding this comment.
obviously make configurable later
| case class PythonWorker(channel: SocketChannel) { | ||
| case class PythonWorker( | ||
| channel: SocketChannel, | ||
| extraChannel: Option[SocketChannel] = None) { |
There was a problem hiding this comment.
Let's call this profile data channel or something?
| time.sleep(1) | ||
|
|
||
|
|
||
| def main(infile, outfile): |
| pickled = pickle.dumps(stats) | ||
| write_with_length(pickled, outfile) | ||
| outfile.flush() | ||
| time.sleep(1) |
There was a problem hiding this comment.
I know yappi says it's fast but 1 second busy loop seems maybe overkill or should be configurable?
| for thread in yappi.get_thread_stats(): | ||
| data = list(yappi.get_func_stats(ctx_id=thread.id)) | ||
| stats.extend([{str(k): str(v) for k, v in d.items()} for d in data]) | ||
| pickled = pickle.dumps(stats) |
There was a problem hiding this comment.
While pickle? Would JSON maybe make more sense so we can interpert more easily in say the Spark UI in the future?
|
Let me make a new PR when it's ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TBD
Why are the changes needed?
TBD
Does this PR introduce any user-facing change?
TBD
How was this patch tested?
Screen.Recording.2025-10-24.at.12.18.24.PM.mov
Was this patch authored or co-authored using generative AI tooling?
No.