Skip to content

Conversation

@EnxDev
Copy link
Contributor

@EnxDev EnxDev commented Nov 19, 2025

SUMMARY

When the body has a vertical scrollbar, scrollbarGutter: 'stable' reserves space for it, making the content area narrower. The header container had scrollbarGutter: 'stable' but no scrollbar, causing a width mismatch.
By:

  • Removing scrollbarGutter: 'stable' from the header container
  • Setting the header width to maxWidth - scrollBarSize when a vertical scrollbar is present
  • The header and body containers now have matching content widths, so the columns align correctly.

BEFORE

Screenshot 2025-11-21 at 19 34 55

AFTER

Screenshot 2025-11-21 at 19 35 12

TESTING INSTRUCTIONS

  1. Open a Table viz and make sure columns are correctly aligned when a scroll bar is visible

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@sadpandajoe sadpandajoe added review:checkpoint Last PR reviewed during the daily review standup review:draft and removed review:checkpoint Last PR reviewed during the daily review standup labels Nov 19, 2025
@geido geido marked this pull request as ready for review November 21, 2025 17:36
@geido geido added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Nov 21, 2025
@dosubot dosubot bot added the viz:charts:table Related to the Table chart label Nov 21, 2025
@github-actions github-actions bot added 🎪 cfb8c78 🚦 building Environment cfb8c78 status: building 🎪 cfb8c78 📅 2025-11-21T17-37 Environment cfb8c78 created at 2025-11-21T17-37 🎪 cfb8c78 ⌛ 48h Environment cfb8c78 expires after 48h 🎪 cfb8c78 🤡 geido Environment cfb8c78 requested by geido and removed 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels Nov 21, 2025
@github-actions
Copy link
Contributor

🎪 Showtime is building environment on GHA for cfb8c78

@github-actions github-actions bot added 🎪 cfb8c78 🚦 deploying Environment cfb8c78 status: deploying 🎪 cfb8c78 🚦 running Environment cfb8c78 status: running 🎪 🎯 cfb8c78 Active environment pointer - cfb8c78 is receiving traffic 🎪 cfb8c78 🌐 54.188.86.245:8080 Environment cfb8c78 URL: http://54.188.86.245:8080 (click to visit) and removed 🎪 cfb8c78 🚦 building Environment cfb8c78 status: building 🎪 cfb8c78 🚦 deploying Environment cfb8c78 status: deploying 🎪 cfb8c78 🚦 running Environment cfb8c78 status: running 🎪 🎯 cfb8c78 Active environment pointer - cfb8c78 is receiving traffic labels Nov 21, 2025
@github-actions
Copy link
Contributor

🎪 Showtime deployed environment on GHA for cfb8c78

Environment: http://54.188.86.245:8080 (admin/admin)
Lifetime: 48h auto-cleanup
Updates: New commits create fresh environments automatically

@sadpandajoe
Copy link
Member

Superset uses Git pre-commit hooks courtesy of pre-commit. To install run the following:

pip3 install -r requirements/development.txt
pre-commit install

A series of checks will now run when you make a git commit.

Alternatively it is possible to run pre-commit by running pre-commit manually:

pre-commit run --all-files

@github-actions github-actions bot removed 🎪 cfb8c78 🚦 running Environment cfb8c78 status: running 🎪 cfb8c78 🌐 54.188.86.245:8080 Environment cfb8c78 URL: http://54.188.86.245:8080 (click to visit) 🎪 cfb8c78 🤡 geido Environment cfb8c78 requested by geido 🎪 cfb8c78 ⌛ 48h Environment cfb8c78 expires after 48h labels Nov 23, 2025
@github-actions github-actions bot removed the 🎪 cfb8c78 📅 2025-11-21T17-37 Environment cfb8c78 created at 2025-11-21T17-37 label Nov 23, 2025
Copy link
Contributor

@alexandrusoare alexandrusoare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido
Copy link
Member

geido commented Nov 24, 2025

Superset uses Git pre-commit hooks courtesy of pre-commit. To install run the following:

pip3 install -r requirements/development.txt
pre-commit install

A series of checks will now run when you make a git commit.

Alternatively it is possible to run pre-commit by running pre-commit manually:

pre-commit run --all-files

It does not seem to be a pre-commit issue, more of an actual pre-commit failure to start. I have restarted CI

@rusackas rusackas merged commit ab8352e into master Nov 24, 2025
143 of 149 checks passed
@rusackas rusackas deleted the enxdev/fix/table-columns branch November 24, 2025 18:25
@sadpandajoe sadpandajoe added the v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch label Nov 25, 2025
sadpandajoe pushed a commit that referenced this pull request Nov 25, 2025
LuisSanchez pushed a commit to LuisSanchez/superset that referenced this pull request Nov 25, 2025
kshi020302 pushed a commit to jl141/superset that referenced this pull request Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugins size/S v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch viz:charts:table Related to the Table chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants