Skip to content

Conversation

@sadpandajoe
Copy link
Member

@sadpandajoe sadpandajoe commented Nov 20, 2025

SUMMARY

The uv pip compile command resolves platform-specific dependencies based on the OS it runs on:

  • macOS: keyring doesn't need secretstorage/jeepney (uses macOS Keychain)
  • Linux: keyring requires secretstorage and jeepney (for D-Bus SecretService backend)

When requirements were compiled on macOS, these Linux-specific transitive dependencies were excluded. CI runs on Linux and expects them to be present.

Updated the script to now run in linux if no on linux to prevent future confusion.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Nov 20, 2025

Code Review Agent Run #238a5d

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: 0fc82a1..0fc82a1
    • requirements/base.txt
    • requirements/development.txt
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

@sadpandajoe sadpandajoe marked this pull request as draft November 20, 2025 02:02
@sadpandajoe sadpandajoe changed the title chore: update dependencies fix: recompile dependencies with linux Nov 20, 2025
@sadpandajoe sadpandajoe marked this pull request as ready for review November 20, 2025 02:33
@aminghadersohi
Copy link
Contributor

approved :D

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 20, 2025
@sadpandajoe sadpandajoe changed the title fix: recompile dependencies with linux fix: recompile dependencies with linux and update generate dependency script Nov 20, 2025
@betodealmeida betodealmeida merged commit 979d385 into master Nov 20, 2025
79 of 81 checks passed
@betodealmeida betodealmeida deleted the fix-check-python-deps branch November 20, 2025 18:42
LuisSanchez pushed a commit to LuisSanchez/superset that referenced this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants