Skip to content

Conversation

@ntheanh201
Copy link
Contributor

@ntheanh201 ntheanh201 commented Dec 27, 2024


Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Control Cache Config (t3c, formerly ORT)
  • Traffic Control Health Client (tc-health-client)
  • Traffic Control Client
  • Traffic Monitor
  • Traffic Ops
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Grove
  • CDN in a Box
  • Automation
  • unknown

What is the best way to verify this PR?

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@zrhoffman zrhoffman added improvement The functionality exists but it could be improved in some way. go version python Pull requests that update Python or Python-related code labels Dec 27, 2024
// under the License.

go 1.23.0
go 1.23.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this will mean that a user cannot compile ATC using Go 1.23.3, and Go 1.23.4 or higher is required. Usually, minor versions are bugfixes and Go language changes are only introduced in major versions, so do we want to require specific minor versions?

Copy link
Contributor Author

@ntheanh201 ntheanh201 Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reason is for aligning the Go version with .env and GO_VERSION is to maintain consistency across the development environment and avoid potential version mismatches.
I understand your perspective about not wanting to be overly restrictive with minor versions.
Would it better if we only watch & change the major/minor versions, and the patch keep 0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go version improvement The functionality exists but it could be improved in some way. python Pull requests that update Python or Python-related code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants