feat: improve Cloudflare challenge handling with clickPositionCallback and configurable waitPeriod

[Yash-Hirgude]

This PR enhances the Cloudflare challenge handling logic by making the click behaviour more flexible and reliable.
Two new options are introduced in postNavigationHooks.ts:

• clickPositionCallback
  Allows users to manually specify the exact coordinates (x, y) where the click should occur.
  This is useful when the default DOM-based position detection fails, or when the challenge layout varies across sites.

• preChallengeSleepSecs
  Optional delay (in milliseconds) inserted before the first click attempt.
  This helps ensure the Cloudflare button and related elements are fully rendered before detection or clicking begins.

Closes #3127

[B4nan]

Suggested change

	let pos = await options.clickPositionCallback(page);
	const pos = await options.clickPositionCallback(page);

[B4nan]

Suggested change

	waitPeriod?: number;
	waitPeriodMillis?: number;

or maybe we should use seconds here, it feels weird to have one time based option in millis and the other in seconds. also, since we wait for one second on each iteration, what about making that time configurable instead of introducing another sleep option in the same loop?

[Yash-Hirgude]

Yes, I will change waitPeriod from milliseconds to seconds.
Also, regarding the initial delay, if we apply the delay before verifying the challenge page, then even non challenge requests will wait unnecessarily. So it would be better to apply the extra delay after we detect the challenge (i.e., only when required).
If you prefer that we still keep a configurable delay before the first click regardless of detection, I can update the code accordingly, just let me know.

Also as per the issue description and after studying the issue #3124 it seems the delay is required only for the first iteration to allow the challenge UI to finish rendering, can you please confirm it.

[B4nan]

The idea is that the 1s delay might not be enough, so we try it 10 times in a loop and escape early once we see we can. That's why I said that one sleep might be enough, since it happens again and again till we pass the challenge.

So it would be better to apply the extra delay after we detect the challenge (i.e., only when required).

You need to wait to be able to verify if it is the challenge page, I dont think there is a way to make this pass immediately for non challenge pages.

[Yash-Hirgude]

Got it, thanks for the clarification.

My initial understanding was that we would wait 1 second to detect whether it’s a challenge page, and then after confirming the challenge, we would wait an additional options.waitPeriod seconds to allow the button position shift to occur before detection.

But understood now that the initial wait itself will be configured and is applied in each iteration, so adding a second delay isn’t necessary. The repeated loop sleeps already give enough time for both detection and passing the challenge.

[B4nan]

This should have a more descriptive name, having sleepSecs and waitPeriodSecs next to each other is quite confusing. Also the comment should mention the default of 1s.

[Yash-Hirgude]

changed the name to initialWaitSecs

[B4nan]

i'd prefer sleep over wait, it means the same and we already use sleep in those options. also not entirely sure if this should be called initial since it happens in each iteration

[Yash-Hirgude]

ok, preChallengeSleepSecs might be a good name in this case.