Skip to content

fix 'add --help' typo, refactor ora to dynamic import, move colors.js #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ixc7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix 'add --help' typo, refactor ora to dynamic import, move colors.js #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bin/apostrophe
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#!/usr/bin/env node

require('shelljs/global');
require('colors');
const { program } = require('commander');
const util = require('../lib/util');
const confUtils = require('../lib/conf-utils');
Expand Down
2 changes: 1 addition & 1 deletion lib/commands/add.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const { stripIndent } = require('common-tags');

module.exports = function (program, version) {
program
.command('add <module type> <module-name>')
.command('add <module-type> <module-name>')
.description(stripIndent`
Add an Apostrophe module with boilerplate configuration to get you started.
- Add "module" for <module type> to add a generic module.
Expand Down
3 changes: 2 additions & 1 deletion lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const cliVersion = require('../package.json').version;
const confUtils = require('./conf-utils');
const packageJson = require('package-json');
const semver = require('semver');
const ora = require('ora');
require('colors');
const { spawn } = require('child_process');

module.exports = util;
Expand Down Expand Up @@ -155,6 +155,7 @@ util.spawnWithSpinner = async function (command, options = {
throw new Error('No command provided to spawnWithSpinner');
}

const ora = await (await import('ora')).default;
const spinner = ora({
text: options.spinnerMessage,
interval: 100,
Expand Down