-
Notifications
You must be signed in to change notification settings - Fork 390
refactor: standardize middleware naming to Authorizer #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -82,7 +82,7 @@ func initParams() *jwt.GinJWTMiddleware { | |||||
|
|
||||||
| IdentityHandler: identityHandler(), | ||||||
| Authenticator: authenticator(), | ||||||
| Authorizator: authorizator(), | ||||||
| Authorizer: authorizator(), | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To maintain consistency with the
Suggested change
|
||||||
| Unauthorized: unauthorized(), | ||||||
| LogoutResponse: logoutResponse(), | ||||||
| TokenLookup: "header: Authorization, query: token, cookie: jwt", | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the refactoring to
Authorizer, the example functionauthorizator()should also be renamed toauthorizer(). This would involve updating both the function call here and its definition on line 235. I've also adjusted the spacing in the suggestion to align this field with the others.