Skip to content

Add experimental AMR Patch methods for cartesian meshes #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
AlexlHer wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Add experimental AMR Patch methods for cartesian meshes #2338

AlexlHer wants to merge 19 commits into from

Conversation

@AlexlHer
Copy link
Member

@AlexlHer AlexlHer commented Dec 5, 2025

No description provided.

AlexlHer added 17 commits December 5, 2025 13:10
@AlexlHer
[arcane:cartesianmesh] Add AMRPatchPosition class to represent positi…
1313d43 
…on of patch in the cartesian mesh

And :
- Add methods to split patches to ensure that patches are always
  regular after coarseZone() call.
@AlexlHer
[arcane:cartesianmesh] Add a method to merge patches (amr-type=3 only)
c4116a8
@AlexlHer
[arcane:cartesianmesh] Introduce properties in CartesianMeshNumbering…
79b8f56 
…Mng to support checkpoints
@AlexlHer
[arcane:cartesianmesh] In CartesianMeshNumberingMng, remove 'Position…
92aba54 
…ToLevel' array

And :
- Add a method to write status of the object,
- Fix an error in updateFirstLevel() (cmgi part),
- Add a method to renumber faces of level 0 (to optimize and support mesh repartitioner)
@AlexlHer
[arcane:cartesianmesh,tests] Update tests arc
8126381
@AlexlHer
[arcane:cartesianmesh] Add methods of the proto "amr_proto"
86b8957 
And use the new methods in CartesianPatchGroup.
@AlexlHer
[arcane:cartesianmesh] Reuse old patches groups to build new patches
d472862
@AlexlHer
[arcane:cartesianmesh] Move merge method in AMRPatchPositionLevelGroup
57ce48d
@AlexlHer
[arcane:cartesianmesh] Add overlap cells layer around patches
cfba975 
And fix 2D patchUp() method

- Managing overlap node and face
@AlexlHer
[arcane:core,cartesianmesh] Fixes for multi-level refinement and para…
b9e30af 
…llel execution
@AlexlHer
[arcane:cartesianmesh] Move some files in internal folder
bfabee8
@AlexlHer
[arcane:cartesianmesh] Add methods to get cells uid around node
cb00b98 
And :
- Add two new patch groups : inPatch and overall,
- Add specific methods for AMR Patch using the numbering mng in CartesianConnectivity, CartesianMesh, CartesianMeshPatch, Cell/Face/NodeDirectionMng,
@AlexlHer
[arcane:cartesianmesh] Restore legacy amr-type=1
c517219
@AlexlHer
[arcane:cartesianmesh] Add doc
38d9a2d
@AlexlHer
[arcane:cartesianmesh] Fix errors in connectivity computing
a4d7f26
@AlexlHer
[arcane:cartesianmesh,tests] Change 3D numbering order
be2f9fe 
And update hashes for faceUID checking.
@AlexlHer
[arcane:cartesianmesh] Add methods to enable overlap cells layer
524392d
@AlexlHer AlexlHer self-assigned this Dec 5, 2025
@AlexlHer AlexlHer added enhancement New feature or request arcane Arcane Component labels Dec 5, 2025
@AlexlHer AlexlHer force-pushed the dev/ah-amr-cartesian branch from 2ceee4f to 70975ed Compare December 5, 2025 13:43
@AlexlHer AlexlHer marked this pull request as draft December 5, 2025 14:38
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 57.34043% with 802 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.56%. Comparing base (4a944bf) to head (70975ed).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...artesianmesh/internal/AMRPatchPositionSignature.cc 0.00% 223 Missing ⚠️
...cane/cartesianmesh/internal/CartesianPatchGroup.cc 65.44% 146 Missing and 33 partials ⚠️
...esianmesh/internal/AMRPatchPositionSignatureCut.cc 0.00% 147 Missing ⚠️
.../arcane/cartesianmesh/CartesianMeshNumberingMng.cc 0.00% 92 Missing ⚠️
...rcane/src/arcane/cartesianmesh/AMRPatchPosition.cc 66.08% 39 Missing ⚠️
...rcane/src/arcane/cartesianmesh/FaceDirectionMng.cc 75.52% 22 Missing and 13 partials ⚠️
...ne/src/arcane/cartesianmesh/CartesianMeshAMRMng.cc 57.14% 18 Missing ⚠️
...rtesianmesh/internal/AMRPatchPositionLevelGroup.cc 52.63% 17 Missing and 1 partial ⚠️
.../src/arcane/cartesianmesh/CartesianConnectivity.cc 89.36% 5 Missing and 5 partials ⚠️
...rcane/src/arcane/cartesianmesh/NodeDirectionMng.cc 92.91% 7 Missing and 2 partials ⚠️
... and 9 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2338      +/-   ##
==========================================
- Coverage   71.72%   71.56%   -0.17%     
==========================================
  Files        2376     2382       +6     
  Lines      172806   174695    +1889     
  Branches    20127    20421     +294     
==========================================
+ Hits       123945   125013    +1068     
- Misses      41398    42165     +767     
- Partials     7463     7517      +54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@AlexlHer AlexlHer

Labels

arcane Arcane Component enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexlHer