-
Notifications
You must be signed in to change notification settings - Fork 158
Transitive Searches #11987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
whatisgalen
wants to merge
44
commits into
dev/8.1.x
Choose a base branch
from
gvm/10644_relations_index_mapping
base: dev/8.1.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Transitive Searches #11987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 45947d2. revert
…nto archesproject-dev/8.0.x pulls latest from head
…nto archesproject-dev/8.0.x pulls latest
…nto archesproject-dev/8.0.x pulls latest from remote
* fixes webpack issues
11628 Create GeoTileGrid es dsl class
…elationship_keys Fix resource relationship keys
…nto archesproject-dev/8.0.x pull latest from remote
relations #10644
relations #10644relations #10644
relations #10644
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
This PR tries to address the question of: Now that the Resource Relations index is removed, how can we make related resources searchable in Elasticsearch (beyond strictly resource-instance tile advanced search)? To answer the question, it proposes a new search-view such that a user can effectively
SELECTrelated instances of a search result set.This PR proposes adding new index mapping fields:
fromrelations: a nested field that stores unidirectional pointers to related resources from the document resource, along with a few properties from the resourcexresource model instance.torelations_graphids: a flat array of dinstinct graphids indicating whether any other resource of those graphids has a relation to the document resourceWhat's the use case?
If I want to find instances of model X such that they are related to the result set of instances of model Y via search filters A, B, and C.
Pseudo bidirectionality
It's not feasible to store all the relations to a given resource, so storing just the graphid accomplishes the minimum of letting you filter in ES for those resources that have any relations to particular Resource Model instances vs those that don't, limiting the scope of the subsequent ORM query to the ResourceXResource model. That query looks like this in
transitive_search_view.py:Issues Solved
Addresses in part #10644 but does not close it as more search infrastructure is needed.
Checklist
Accessibility Checklist
Developer Guide
Ticket Background
Further comments