Skip to content

Conversation

@whatisgalen
Copy link
Member

@whatisgalen whatisgalen commented Apr 27, 2025

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Issues Solved

Closes #12003

Checklist

  • I targeted one of these branches:
    • dev/8.0.x (under development): features, bugfixes not covered below
    • dev/7.6.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

  • Sponsored by:
  • Found by: @
  • Tested by: @
  • Designed by: @

Further comments

@whatisgalen whatisgalen changed the title Gvm/12003 bulk index err reporting Fix/improve bulk index error reporting Apr 27, 2025
@whatisgalen whatisgalen requested a review from njkim May 1, 2025 13:12
@whatisgalen whatisgalen requested review from apeters and removed request for njkim May 15, 2025 17:25
@apeters
Copy link
Member

apeters commented Jun 5, 2025

@whatisgalen what's the best way to test this?

@whatisgalen
Copy link
Member Author

whatisgalen commented Jun 9, 2025

@whatisgalen what's the best way to test this?

@apeters If you manually (via postgres) save something like this to a bad nodevalue to tile.tiledata and then try to index that resource, you should be able to test this PR for whether it surfaces the specific document_parsing_exception that comes up

@apeters
Copy link
Member

apeters commented Jun 20, 2025

@whatisgalen Can you give me exact steps to repro this? I've tried adding "bad" data to a non-localized string datatype but I"m seeing different errors unrelated to your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bulk Index exception handling doesn't surface the failing document and its error

3 participants