Skip to content

Conversation

@jkemper-pca
Copy link
Contributor

This fixes the issue where the display value being calculated for a ResourceInstanceDataType object wasn't using the language value passed to the function and always defaulted to the currently active language.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

The kwargs parameter is now passed through the get_display_value() function to the displayname() function being called within it to get the string displayname value.

Issues Solved

Closes #12538

Checklist

  • I targeted one of these branches:
    • dev/8.1.x (under development): features, bugfixes not covered below
    • dev/8.0.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/7.6.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

Further comments

I have targeted this change to the dev/7.6.x branch because I found it on our 7.6 install but I also believe this to be a bug in the 8.x version as well. If it makes more sense to target v8 I can change the PR.

@chiatt chiatt self-requested a review December 30, 2025 21:11
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry to the 7.6.20 release notes?

@jkemper-pca
Copy link
Contributor Author

@chiatt, added.

I was waiting to see if targeting 7.6.x was fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants