Skip to content

Conversation

@jgwest
Copy link
Member

@jgwest jgwest commented Jun 13, 2025

What does this PR do / why we need it:

  • I previously noticed that an expected error was not being filtered by our 'unexpected errors check'
2025-06-11T23:40:12Z ERROR Reconciler error '{"controller":' '"rolloutmanager",' '"controllerGroup":' '"argoproj.io",' '"controllerKind":' '"RolloutManager",' '"RolloutManager":' '{"name":"test-rollouts-manager-2","namespace":"argo-rollouts"},' '"namespace":' '"argo-rollouts",' '"name":' '"test-rollouts-manager-2",' '"reconcileID":' '"2794f12c-8cef-4892-ba2a-6e154a8fdb32",' '"error":' '"clusterrolebindings.rbac.authorization.k8s.io' '\"argo-rollouts\"' already 'exists"}'
  • Grepping out this error is difficult due to use of ' " \ characters, so I've just switched to using simple regexp to ignore that punctuation.

@jgwest jgwest force-pushed the fix-expected-error-june-2025 branch from 6ae694f to df9c4d9 Compare June 13, 2025 18:01
@jparsai
Copy link
Collaborator

jparsai commented Jun 16, 2025

LGTM @jgwest

@jgwest
Copy link
Member Author

jgwest commented Jun 16, 2025

Thanks @jparsai!

@jgwest jgwest merged commit 5acdf66 into argoproj-labs:main Jun 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants