Skip to content

Conversation

@jgwest
Copy link
Member

@jgwest jgwest commented Jul 31, 2025

What does this PR do / why we need it:

  • Fix simple race condition in traffic metric/plugin E2E test

Failing case looks like this within Argo Rollouts Pod:

[jgw@localhost-lan argo-rollouts-manager]$ k logs pod/argo-rollouts-c854d44bc-ftlss
time="2025-07-31T02:43:31Z" level=info msg="Argo Rollouts starting" version=vv1.8.3+49fa151
time="2025-07-31T02:43:31Z" level=info msg="Creating event broadcaster"
time="2025-07-31T02:43:31Z" level=info msg="Setting up event handlers"
time="2025-07-31T02:43:31Z" level=info msg="Setting up experiments event handlers"
time="2025-07-31T02:43:31Z" level=info msg="Setting up analysis event handlers"
time="2025-07-31T02:43:31Z" level=info msg="Downloading plugin argoproj-labs/gatewayAPI from: https://test-update-traffic-plugin"
time="2025-07-31T02:43:31Z" level=fatal msg="Failed to download plugins: failed to download plugin from https://test-update-traffic-plugin: failed to download file from https://test-update-traffic-plugin: Get \"https://test-update-traffic-plugin\": dial tcp: lookup test-update-traffic-plugin on 172.30.0.10:53: no such host"

Have you updated the necessary documentation?

  • Documentation update is required by this PR, and has been updated.

How to test changes / Special notes to the reviewer:

@jgwest jgwest force-pushed the fix-plugin-e2e-test-may-2025 branch from 4091cfd to e996dc2 Compare July 31, 2025 05:56
@jparsai
Copy link
Collaborator

jparsai commented Jul 31, 2025

LGTM

@svghadi
Copy link

svghadi commented Jul 31, 2025

/lgtm
/approve

@jgwest jgwest merged commit a100fc1 into argoproj-labs:main Jul 31, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants