feat(ImageUpdater): Provide option in Argo CD CR to enable/disable image updater #1897

dkarpele · 2025-10-04T19:04:33Z

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:
Image Updater: Provide option in Argo CD CR to enable/disable image updater

Have you updated the necessary documentation?

[yes] Documentation update is required by this PR.
[yes] Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Create a new section in Argo CD CR spec to enable/disable argocd image updater.
Image Updater CRD: https://github.com/argoproj-labs/argocd-image-updater/blob/crd/api/v1alpha1/imageupdater_types.go
If Argo CD Image Updater is enabled in the Argo CD CR, then the operator has to create sa, role, cluster role, role binding, cluster role binding, deployment , secret, cm, ImageUpdater CR.
The required resources are described in https://github.com/argoproj-labs/argocd-image-updater/tree/crd/config
If the Image Updater is disabled in the spec, then the associated resources will be removed as well.
ImageUpdater was added to go.mod with

go get github.com/argoproj-labs/argocd-image-updater@crd
go mod tidy

How to test changes / Special notes to the reviewer:
Tests and documentation will be created ASAP.
To test it manually you can

create/edit/delete examples/argocd-image-updater.yaml
kubectl apply -f examples/argocd-image-updater.yaml
launch argocd operator as usual

Resources will be reconciled.

svghadi

Thanks @dkarpele for working on this. Looks good overall. I have left some comments.

We should also bundle the ImageUpdater CRD into operator, similar to how we handle others here.
In the PR description, it mentions pulling from the crd branch in go.mod:
```
go get github.com/argoproj-labs/argocd-image-updater@crd
```
Is there a specific reason for using the crd branch instead of main or a release branch/tag?

controllers/argocd/image_updater.go

svghadi · 2025-10-06T03:47:31Z

controllers/argocd/image_updater.go

+				{
+					NamePattern: "app-name-pattern",
+					Images: []imageupdaterv1alpha1.ImageConfig{
+						{
+							Alias:     "image-alias",
+							ImageName: "image-name",
+						},


Are these placeholder values or actual ones? I haven’t looked into the image-updater project yet, so just confirming.

Yes, these are placeholders. NamePattern, Alias, ImageName are all mandatory, so we should give them some names.

svghadi · 2025-10-06T03:53:30Z

controllers/argocd/image_updater.go

+
+func (r *ReconcileArgoCD) reconcileImageUpdaterConfigurationCR(cr *argoproj.ArgoCD) error {
+
+	defaultImageUpdaterConfigurationCR := &imageupdaterv1alpha1.ImageUpdater{


Just trying to understand the use case for having a default ImageUpdater CR?
Is it meant to serve as a catch-all configuration for all image update operations, or is the expectation that users should modify this default ImageUpdater CR to suit their needs, rather than creating new ones?

Users can modify this CR or create a new one.
My initial idea was to create a basic ImageUpdater CR that can help user to start working with image updater. @chengfang do you think we should have default ImageUpdater CR or not?

It should be straightforward for users to create their ImageUpdater CR, and likely in their application git repo. I imagine most users will probably not actually use or modify this default CR for their purpose. I feel we can remove it to avoid the runtime overhead.

svghadi · 2025-10-06T04:05:29Z

controllers/argocd/imageUpdater.go

+	podSpec.Containers = []corev1.Container{{
+		Command:         []string{"/manager"},
+		Args:            []string{"run"},
+		Image:           argoutil.CombineImageTag(DefaultImageUpdaterImage, DefaultImageUpdaterTag),


We should make this configurable via env var so that downstream images can be set through the CSV in gitops-operator.

For ref:

argocd-operator/common/keys.go

Line 176 in ef71979

ArgoCDDexImageEnvName = "ARGOCD_DEX_IMAGE"

svghadi · 2025-10-06T04:08:48Z

controllers/argocd/image_updater.go

+		Command:         []string{"/manager"},
+		Args:            []string{"run"},
+		Image:           argoutil.CombineImageTag(DefaultImageUpdaterImage, DefaultImageUpdaterTag),
+		ImagePullPolicy: corev1.PullAlways,


There are ongoing efforts to make the pull policy configurable, just wanted to highlight that.

dkarpele · 2025-10-06T14:37:21Z

In the PR description, it mentions pulling from the crd branch in go.mod:
go get github.com/argoproj-labs/argocd-image-updater@crd

Is there a specific reason for using the crd branch instead of main or a release branch/tag?

The reason is that at the moment crd development of image updater goes in crd branch (not master). When we make the crd version "main" we will update the dependencies here to use

go get github.com/argoproj-labs/argocd-image-updater@main

dkarpele · 2025-10-06T18:13:30Z

Thanks for the review @svghadi
I addressed your requests and also added Image Updater's documentation.

chengfang · 2025-10-06T20:01:57Z

Makefile

+get-image-updater-crd: ## Download Image Updater CRD.
+	@echo "downloading image updater crd"
+	@curl -sSLo config/crd/bases/argocd-image-updater.argoproj.io_imageupdaters.yaml https://raw.githubusercontent.com/argoproj-labs/argocd-image-updater/crd/config/crd/bases/argocd-image-updater.argoproj.io_imageupdaters.yaml
+


do we still need this target now that the ImageUpdater crd is bundled in?

I was thinking it could be useful in case someone wants to update argocd-image-updater.argoproj.io_imageupdaters.yaml. The original of this file is located in Image Updater repo and to reflect the future changes in this crd the target get-image-updater-crd: can be used.

dkarpele · 2025-10-07T16:14:13Z

@svghadi

I removed ImageUpdater CR as discussed.
As a result we don't need to update go.mod with ImageUpdater dependency.
I added unit tests to controllers/argocd/image_updater_test.go.
e2e tests will be created later (end of October), after ImageUpdater CRD release 1.0.0. This is because we can't create Deployment properly (image link leads to an old version of ImageUpdater), see GITOPS-8016.

I don't plan any more changes in this PR.

svghadi · 2025-10-09T14:26:49Z

controllers/argocd/util.go

+	// Add new predicate to delete ImageUpdater Resources. The predicate watches the Argo CD CR for changes to the `.spec.ImageUpdater.Enabled`
+	// field. When a change is detected that results in image updater being disabled, we trigger deletion of image updater resources


I was thinking we could let the main reconcile handle the deletion when the component is disabled.
Predicates are generally meant to be lightweight filters that decide whether an event should be queued or skipped, rather than performing side-effect operations like updates or deletions. We already have a few places in the operator doing this, but it might be something we can gradually refactor later for consistency. Thoughts?

Yes, that makes sense. Initially I created the same predicate as deleteNotificationsPred.
The main problem with deletion is that the order of resource deletion (deployment first) is different from resource creation (deployment last). To handle this I

removed predicate for ImageUpdater

created 2 functions: reconcileImageUpdaterControllerEnabled and reconcileImageUpdaterControllerDisabled.

Each reconcile function (reconcileImageUpdaterDeployment, reconcileImageUpdaterClusterRoleBinding etc.) handles deletion itself.

…age updater Signed-off-by: Denis Karpelevich <[email protected]>

svghadi

LGTM. Thanks

dkarpele force-pushed the dk-GITOPS-7525 branch from fb52a2a to b745b20 Compare October 4, 2025 19:11

dkarpele changed the title ~~feat(ImageUpdater): Add ImageUpdater controller~~ feat(ImageUpdater): Provide option in Argo CD CR to enable/disable image updater Oct 4, 2025

dkarpele force-pushed the dk-GITOPS-7525 branch from b745b20 to 65d7cc8 Compare October 4, 2025 19:26

svghadi requested changes Oct 6, 2025

View reviewed changes

dkarpele force-pushed the dk-GITOPS-7525 branch from ba72d19 to 082fc04 Compare October 6, 2025 18:12

dkarpele requested a review from svghadi October 6, 2025 18:12

dkarpele force-pushed the dk-GITOPS-7525 branch from 082fc04 to 788b201 Compare October 6, 2025 18:20

chengfang reviewed Oct 6, 2025

View reviewed changes

dkarpele force-pushed the dk-GITOPS-7525 branch 2 times, most recently from 26f9a2c to d1c16bf Compare October 7, 2025 16:14

dkarpele force-pushed the dk-GITOPS-7525 branch from d1c16bf to 2c90cf0 Compare October 9, 2025 12:55

svghadi reviewed Oct 9, 2025

View reviewed changes

dkarpele force-pushed the dk-GITOPS-7525 branch from 2c90cf0 to d186084 Compare October 9, 2025 19:06

dkarpele requested a review from svghadi October 9, 2025 19:41

chengfang approved these changes Oct 14, 2025

View reviewed changes

feat(ImageUpdater): Provide option in Argo CD CR to enable/disable im…

85735e3

…age updater Signed-off-by: Denis Karpelevich <[email protected]>

dkarpele force-pushed the dk-GITOPS-7525 branch from d186084 to 85735e3 Compare October 14, 2025 18:31

svghadi approved these changes Oct 15, 2025

View reviewed changes

svghadi merged commit 75d8bc3 into argoproj-labs:master Oct 15, 2025
7 checks passed


		func (r ReconcileArgoCD) reconcileImageUpdaterConfigurationCR(cr argoproj.ArgoCD) error {

		defaultImageUpdaterConfigurationCR := &imageupdaterv1alpha1.ImageUpdater{

		// Add new predicate to delete ImageUpdater Resources. The predicate watches the Argo CD CR for changes to the `.spec.ImageUpdater.Enabled`
		// field. When a change is detected that results in image updater being disabled, we trigger deletion of image updater resources

feat(ImageUpdater): Provide option in Argo CD CR to enable/disable image updater #1897

feat(ImageUpdater): Provide option in Argo CD CR to enable/disable image updater #1897

Uh oh!

Conversation

dkarpele commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svghadi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dkarpele commented Oct 6, 2025

Uh oh!

dkarpele commented Oct 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dkarpele commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svghadi Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dkarpele Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

svghadi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dkarpele commented Oct 4, 2025 •

edited

Loading

svghadi left a comment •

edited

Loading

dkarpele commented Oct 7, 2025 •

edited

Loading

svghadi Oct 9, 2025 •

edited

Loading

dkarpele Oct 9, 2025 •

edited

Loading