fix: Remove dependency on argocd-redis secret #1900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparsai
commented
Oct 8, 2025
| container := deploymentFixture.GetTemplateSpecContainerByName(argoCDAgentPrincipalName, *principalDeployment) | ||
| Expect(container).ToNot(BeNil()) | ||
| Expect(container.Image).To(Equal("quay.io/argoprojlabs/argocd-agent:v0.3.2")) | ||
| Expect(container.Image).To(Equal("quay.io/jparsai/argocd-agent:test")) |
Collaborator
Author
There was a problem hiding this comment.
I have to use my image, since latest agent image is not having this fix yet. Once we have new image I will change it.
jgwest
requested changes
Oct 8, 2025
| redisSecret := &corev1.Secret{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "argocd-redis", | ||
| Name: argocdagent.PrincipalRedisSecretname, |
Member
There was a problem hiding this comment.
Would it make sense to remove this code where we create the Redis Secret? I presume the Secret will be eventually be created by the ArgoCD operator code, and we just need to wait for it. WDYT?
jparsai
force-pushed
the
redis-secret
branch
2 times, most recently
from
deaefbd to
5b4f2c9
Compare
Signed-off-by: Jayendra Parsai <[email protected]>
jgwest
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bug
This PR is to use
argocd-redis-initial-passwordsecret instead ofargocd-redisto get redis passwordFixes https://issues.redhat.com/browse/GITOPS-7837