Skip to content

fix: return empty instead of error if cache unavailable #25072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −1
Open

fix: return empty instead of error if cache unavailable #25072

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72a4cac
fix: return empty instead of error if cache unavailable
pjiang-dev Oct 24, 2025
7598bda
update error message
pjiang-dev Oct 27, 2025
244ead6
Update server/application/application.go
pjiang-dev Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion server/application/application.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1771,7 +1771,8 @@ func (s *Server) ManagedResources(ctx context.Context, q *application.ResourcesQ
return s.cache.GetAppManagedResources(a.InstanceName(s.ns), &items)
})
if err != nil {
return nil, fmt.Errorf("error getting cached app managed resources: %w", err)
log.Warnf("error getting cached app managed resources for %s/%s, cache unavailable, returning empty managed resources: %v", a.Namespace, a.Name, err)
return &application.ManagedResourcesResponse{Items: []*v1alpha1.ResourceDiff{}}, nil
}
res := &application.ManagedResourcesResponse{}
for i := range items {
Expand Down
Loading