-
-
Couldn't load subscription status.
- Fork 2.7k
Bump Rockchip Vendor to rkr6.1 #8719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Walkthrough
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
once merged default repo should be switched at linux-rockchip. |
|
rock-3a: https://paste.armbian.com/isoyojisuj seems ok. Got a few pcie errors but can also be because m.2 slot was empty. |
|
Based on armbian/linux-rockchip@e54469c, I guess Mali Valhall needs these changes? -CONFIG_MALI_BIFROST=y
-CONFIG_MALI_PLATFORM_NAME="rk"
-CONFIG_MALI_CSF_SUPPORT=y
-CONFIG_MALI_BIFROST_EXPERT=y
-CONFIG_MALI_BIFROST_DEBUG=y
+CONFIG_MALI_VALHALL=y
+CONFIG_MALI_VALHALL_PLATFORM_NAME="rk"
+CONFIG_MALI_VALHALL_EXPERT=y
+CONFIG_MALI_VALHALL_DEBUG=y |
Yeah true, I need to add that change for RK3588 (mali valhall) since they split the driver to bifrost and valhall. I think the Bifrost flag is still needed for RK3568/RK3576/… builds |
|
|
Good point about |
|
...and, it worked, with a small caveat: (probably a missing entry in the dts). But, it's just a warning, should be safe to ignore. |
|
Getting lots of rockchip-dmc errors in dmesg: https://paste.armbian.com/ewuvisawes |
do you have some uptime info? Or did they come rather quickly? |
|
Just a few seconds uptime and then sent armbianmonitor in both cases. |
|
Only the rockchip dmc debug driver seems to have gotten any relevant changes. I will keep monitoring on my devices for similar behavior. I looked at:
|
DMC frequencies are handled via ATF (bl31) and dts is only used for voltage lookup. Rk3588 dts has a default dvfs table for dmc, and it is supposed to go 528Mhz when idling. But to go 528Mhz your ATF should provide 528Mhz first. If it does not you get the above error message. Overall how dvfs works rokchip bsp is quite bullshit, so the error message should be quite harmless. I think the question is why your ATF does not provide 528Mhz. If i am right, this issue should be gone when you update your full bootlader (you need to change the ATF (bl31) blob) to verify my theory i have a tool to communciate with ATF here is a short how to use, and below gives the desired 528Mhz, i guess in your case it should not be there, and should be there when you update your atf. |
|
Will test soon on RK3576 |
test@orangepi5-plus:~/smccc/pysmccc$ sudo python3.12 rktune mem getclocks
INFO | 0) 528Mhz
INFO | 1) 1068Mhz
INFO | 2) 1560Mhz
INFO | 3) 2112Mhz
INFO | 4) 0Mhz
INFO | 5) 0Mhz
test@orangepi5-plus:~/smccc/pysmccc$ uname -a
Linux orangepi5-plus 6.1.115-vendor-rk35xx #1 SMP Mon Sep 1 17:12:42 UTC 2025 aarch64 aarch64 aarch64 GNU/Linuxtest@orangepi5-plus:~/smccc/pysmccc$ sudo python3.12 rktune mem getclocks
INFO | 0) 528Mhz
INFO | 1) 1068Mhz
INFO | 2) 1560Mhz
INFO | 3) 2112Mhz
INFO | 4) 0Mhz
INFO | 5) 0Mhz
test@orangepi5-plus:~/smccc/pysmccc$ uname -a
Linux orangepi5-plus 6.1.118-vendor-rk35xx #1 SMP Sun Oct 5 21:19:02 UTC 2025 aarch64 aarch64 aarch64 GNU/LinuxLooks the same. Did not do anything to the boot loader |
|
Testing mali bifrost on rk3566 |
Ok then my theory did not hold up |
It's actually Mesa Panfrost, which has nothing to do with bifrost/libmali closed source driver. |
Can you share your resusts? |

Description
This PR switches to the latest rockchip vendor kernel release 6.1-rkr6.1 from rkr5.1
Now we need some people to test if their usecases still work.
I went ahead and made sure it compiles correctly and runs on RK3588 but haven't tested much further
How Has This Been Tested?
Boot:
Mali:
Panfrost/Panthor:
Video Processing:
Acknowledgement