filogic/bpi-r4 - fix edge kernel config #8772
Conversation
github-actions
bot
added
11
WalkthroughThis PR replaces the filogic edge kernel config file (config/kernel/linux-filogic-edge.config) with a large reconfiguration: many CONFIG_* symbols are added or changed across CPUfreq, ARM64 errata/arch options, randomization/energy model, perf/cgroups, netfilter/nf_tables/xtables/IPv4/IPv6/IPVS, tunneling/IPSEC/MPTCP, extensive driver/PHY/USB/PCIe/MTK hardware entries, crypto algorithms and ARM64 crypto offloads, filesystems (NFS/CIFS/XFS/EXT4/UBIFS/SquashFS/ZRAM/overlayfs), module system options (module compression/unload), and various debug/hardening options. Separately, config/sources/families/filogic.conf gains only commented alternative kernel source/branch lines and a comment; no active kernel source or branch assignments were changed. Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (4)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
coderabbitai
bot
requested review from
EvilOlaf,
chainsx,
chraac,
igorpecovnik,
krachlatte and
rpardini
tabrisnet
force-pushed
the
tabrisnet_filogic_edge_6.16-fix
branch
7 times, most recently
from
7292dea to
094f00b
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
config/kernel/linux-filogic-edge.config (3)
99-99: Verify the userspace default CPU frequency governor choice.Setting
CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACEis unusual for an embedded router/gateway device. Typically,schedutilorondemandwould be more appropriate defaults as they provide automatic frequency scaling without requiring userspace configuration.Note that
CONFIG_CPU_FREQ_GOV_SCHEDUTIL=yis built-in, so consider changing line 99 to use schedutil as the default instead:-CONFIG_CPU_FREQ_DEFAULT_GOV_USERSPACE=y +CONFIG_CPU_FREQ_DEFAULT_GOV_SCHEDUTIL=yOr verify if there's a specific reason for requiring userspace governor management.
470-486: Extensive SCSI and enterprise RAID support added.The addition of SCSI infrastructure and enterprise RAID controller drivers (MegaRAID, MPT3SAS, MPI3MR) is somewhat unusual for a router configuration. However, since the BPI-R4 has PCIe slots, users could add storage controllers, and the edge branch is intended for experimentation.
If these came from the OpenWRT defconfig base, consider whether they're needed for typical BPI-R4 use cases, though keeping them as modules has minimal impact.
724-732: Consider whether NFS v2 and legacy DNS support are needed.The configuration enables comprehensive NFS support including:
CONFIG_NFS_V2=m- NFSv2 is deprecated and has known security limitationsCONFIG_NFS_USE_LEGACY_DNS=y- Uses legacy DNS resolution behaviorWhile both are implemented as modules (minimal impact), consider whether NFSv2 support is necessary for your use case, as most modern systems use NFSv3 or v4.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
config/kernel/linux-filogic-edge.config(15 hunks)config/sources/families/filogic.conf(1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: tabrisnet
PR: armbian/build#8746
File: config/kernel/linux-filogic-edge.config:344-470
Timestamp: 2025-10-11T19:52:54.648Z
Learning: The chainsx/linux-filogic kernel (legacy branch) for BPI-R4 uses out-of-tree proprietary drivers (CONFIG_NET_DSA_AN8855, CONFIG_AIROHA_EN8801SC_PHY, CONFIG_AIR_AN8855_PHY, CONFIG_MDIO_AN8855, CONFIG_MFD_AIROHA_AN8855). The frank-w/BPI-Router-Linux kernel (current and edge branches) uses mainline kernel drivers instead: CONFIG_NET_DSA_MT7530 for the DSA switch and CONFIG_MEDIATEK_2P5GE_PHY for PHY support. These provide equivalent functionality for BPI-R4 networking.
Learnt from: tabrisnet
PR: armbian/build#0
File: :0-0
Timestamp: 2025-08-30T04:13:16.457Z
Learning: Armbian kernel configuration files like linux-filogic-current.config are autogenerated overlays on top of arch defconfig. Comments added manually will be lost during future updates by maintainers, and explicit "CONFIG_OPTION is not set" statements aren't needed for mutually exclusive options since these are overlay configs that only specify changes from the base configuration.
📚 Learning: 2025-09-11T06:12:54.213Z
Learnt from: SuperKali
PR: armbian/build#8609
File: config/boards/nanopi-r76s.conf:5-5
Timestamp: 2025-09-11T06:12:54.213Z
Learning: In the Armbian build system, board family configuration files (like config/sources/families/rk35xx.conf) can inherit kernel branch definitions from common include files (like config/sources/families/include/rockchip64_common.inc). Even if a branch like "edge" is not defined directly in the family conf file, it may be available through the sourced include file.
Applied to files:
config/sources/families/filogic.conf
📚 Learning: 2025-06-25T03:42:09.086Z
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:42:09.086Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, KERNELSOURCE is explicitly declared when using unofficial or 3rd party kernel repositories (like the "dev" branch using https://github.com/apritzel/linux), but can be omitted when using the standard mainline kernel (like the "edge" branch) since it will fall back to the default mainline source.
Applied to files:
config/sources/families/filogic.conf
📚 Learning: 2025-10-13T02:26:18.249Z
Learnt from: tabrisnet
PR: armbian/build#8746
File: config/sources/families/filogic.conf:61-68
Timestamp: 2025-10-13T02:26:18.249Z
Learning: In the Armbian build system, the "edge" kernel branch is intended to be bleeding-edge and experimental. It does not require hardware testing or stability verification before merging, as it's expected to contain potentially unstable or untested code for early adopters and developers.
Applied to files:
config/sources/families/filogic.conf
📚 Learning: 2025-10-11T19:52:54.648Z
Learnt from: tabrisnet
PR: armbian/build#8746
File: config/kernel/linux-filogic-edge.config:344-470
Timestamp: 2025-10-11T19:52:54.648Z
Learning: The chainsx/linux-filogic kernel (legacy branch) for BPI-R4 uses out-of-tree proprietary drivers (CONFIG_NET_DSA_AN8855, CONFIG_AIROHA_EN8801SC_PHY, CONFIG_AIR_AN8855_PHY, CONFIG_MDIO_AN8855, CONFIG_MFD_AIROHA_AN8855). The frank-w/BPI-Router-Linux kernel (current and edge branches) uses mainline kernel drivers instead: CONFIG_NET_DSA_MT7530 for the DSA switch and CONFIG_MEDIATEK_2P5GE_PHY for PHY support. These provide equivalent functionality for BPI-R4 networking.
Applied to files:
config/sources/families/filogic.conf
🔇 Additional comments (5)
config/kernel/linux-filogic-edge.config (4)
118-411: Networking configuration expansion looks appropriate for router use case.The extensive networking features (netfilter, nftables, iptables, conntrack helpers, TLS offload, tunneling protocols) align well with the BPI-R4's router/gateway functionality. The modular approach (most features as modules) allows flexibility without bloating the kernel image.
752-821: Security hardening and crypto configuration looks good.The security features (
FORTIFY_SOURCE,HARDENED_USERCOPY,RANDOMIZE_BASE) provide good baseline hardening. The extensive crypto algorithm support with ARM64 Crypto Extensions acceleration is appropriate for a router handling VPN, TLS, and encryption workloads.
836-837: Note: Aggressive panic settings for experimental edge branch.The combination of
CONFIG_PANIC_ON_OOPS=yandCONFIG_PANIC_TIMEOUT=10means any kernel oops will trigger an automatic reboot after 10 seconds. While this provides automatic recovery for production systems, it can make debugging more difficult during development of an experimental edge kernel.Since you've already tested and deployed this configuration, this is just an FYI. Consider whether you want to disable
PANIC_ON_OOPSduring active development to capture more debugging information.
532-569: Cellular modem support addition is appropriate for router use case.The comprehensive WWAN/cellular modem support (USB and PCIe via MHI, QMI/MBIM protocols, MediaTek T7xx) enables BPI-R4 users to add cellular modems for WAN connectivity or failover scenarios. Implementing these as modules is the right approach.
config/sources/families/filogic.conf (1)
62-66: Consider pinning to a specific commit hash instead of a branch for reproducibility.The personal fork exists and is accessible, but relying on a branch reference creates maintenance risk. Since frank-w/BPI-Router-Linux shows no recent activity on the 6.16-rsslro branch (last commit in July 2025, before the kernel.org 6.16.12 release on Oct 12, 2025) and there is no public plan to merge the 6.16.12 patch, this appears to be a long-term reliance on the tabrisnet fork rather than temporary.
To ensure reproducibility and avoid unexpected changes:
- Use a specific commit hash (e.g., from the current head of
6.16.12-rsslro) instead of a branch reference- Document why the personal fork is necessary and when/if you plan to switch back to frank-w's repository
|
You could also leave the kernel source as it is and add the incremental patch via patch folder? |
I couldn't find the incremental patch from |
seems that I have to edit some of the patches. working on it |
|
There should be incremental patches for every minor step there. These can be just applied after each other like here: https://github.com/armbian/build/tree/main/patch/kernel/archive/odroidxu4-6.6 |
yeah, I tried that. there are some things backported into the stable tree from the same sources that |
tabrisnet
force-pushed
the
tabrisnet_filogic_edge_6.16-fix
branch
from
094f00b to
bf29a41
Compare
and as noted, the kernel.org incr doesn't include the -rc patches |
filogic 6.16 - produce 6.16.12 patch from rebasing the stable tree
tabrisnet
force-pushed
the
tabrisnet_filogic_edge_6.16-fix
branch
from
bf29a41 to
5792470
Compare
2 participants
Description
Fixes for
6.16-rsslrokernel config, also update to6.16.12.Basically took the OpenWRT
defconfig, fed it throughrewrite-kernel-config, then manually added back as much stuff as I could find including copying the lines missing vsdiff -pu linux-filogic-current.config linux-filogic-edge.config.For review purposes, assume that most of the
config/kernel/linux-filogic-edge.configchanges are not interesting.Yes, this means you: @coderabbitai.
This likely only deserves a tag of
size/small.How Has This Been Tested?
iperf3[although it requires significant config from user-space - details here & here]