Open
Conversation
- Implemented athuler#17
Implemented athuler#21
Added optional return types, removed None comparison with == and some redundant parentheses. Began testing on live timing. Added getStopById to Routes and Systems for use with live timing.
Vehicle getNextStop() and getEtas() use 3rd party API to get stops and times. Stop getNextVehicle() and getEtas() gets vehicles and times.
Run Tests on Pull Requests
…oes not wish to manually refresh systems.
Author
|
You may need to merge |
Author
|
That looked awfully messy but this PR should include I made the caches into dictionaries to allow for instant lookups when using any |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have separated the caching mechanism I came up with into this branch. I understand if this isn't what you had in mind as the caches are stored with each object, and I'm willing to try to implement time based refreshing in some manner in the future.