-
Notifications
You must be signed in to change notification settings - Fork 13
building from source task #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
UncleGrumpy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very cool feature! One that has been on my todo list to add to the atomvm_rebar3_plugin for a while. I work much more in Erlang, so my Elixir is not that great, but I did spot a few problems, and have some suggestions on improving usability.
| @@ -0,0 +1,303 @@ | |||
| defmodule Mix.Tasks.Atomvm.Esp32.Build do | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file (or any contribution to AtomVM and related projects) should begin with copyright and license info in a comment header. You can look at the other files in this repo for a template of what should be contained there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a LICENSE file in this project, thats why any of these files in this project does not have a header.
I will fix other comments meanwhile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies! It’s been a while since I worked on this plugin myself and I completely forgot that this repo didn’t have headers in the files. That may be something we want to add in the future so that any files from the plugin used for other projects will already include the correct license and copywrite.
|
It might also be good to consider allowing a ESP-IDF docker image. I suspect many more Elixir developers will already have docker installed (or at least be more familiar with it than ESP-IDF), so it would be extra cool to pull in a docker image of ESP-IDF if they don't already have it installed. |
|
Hey @UncleGrumpy , when i try to build AtomVM , the build fails because we are using the the |
|
Added docker feat based on this |
the purpose from this task is to make easy to test Elixir AtomVM with main branch code from the AtomVM repository for ESP32.
this task requires
idf.pyinstalled ordockerfor compiling the AtomVM from source.feel free to comment any issue in the implementation as well.
Thank you for your attention.
Using ESP-IDF Docker container