Skip to content

fix sporadic failures to load DLLs by lazy loading them #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tgummerer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix sporadic failures to load DLLs by lazy loading them #74

tgummerer wants to merge 1 commit into from
+11 −9

Conversation

@tgummerer
Copy link

@tgummerer tgummerer commented Apr 17, 2025

On Windows DLL loading sometimes fails for spurious reasons. The panic is always in the following form:

syscall.MustLoadDLL(...)
	/opt/hostedtoolcache/go/1.21.1/x64/src/syscall/dll_windows.go:94
github.com/atotto/clipboard.init()
	/home/runner/go/pkg/mod/github.com/atotto/[email protected]/clipboard_windows.go:22 +0x347

This appears to be happening while loading the application, and was a frequent issue in CI tests in github.com/pulumi/pulumi. We can fix this by lazy loading the DLLs instead. We've been using this fix in our go.mod, using a replace statement (see pulumi/pulumi#17410), but would love to get this upstreamed, so we can remove that replace, and hopefully it helps others as well.

@tgummerer tgummerer mentioned this pull request Apr 17, 2025
Open
@tgummerer tgummerer mentioned this pull request May 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tgummerer