Skip to content

209 scatterplot on seats page that displays devs providing estimates on a grid #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
austenstone wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

209 scatterplot on seats page that displays devs providing estimates on a grid #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bdc005
feat: add loading indicator and scatter chart for seat activity in Co…
austenstone May 27, 2025
0d948de
Merge branch 'main' into 209-scatterplot-on-seats-page-that-displays-…
austenstone Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 16 additions & 59 deletions frontend/src/app/main/copilot/copilot-seats/copilot-seat/copilot-seat.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,22 @@ <h2>{{ seat.assignee.login }}</h2>
></highcharts-chart>
</mat-card-content>
</mat-card>

<mat-card class="chart-card">
<mat-card-content>
<div *ngIf="loading" class="loading-indicator">
<p>Loading activity data... This may take a moment.</p>
<div class="spinner"></div>
</div>
<highcharts-chart
*ngIf="!loading"
[Highcharts]="Highcharts"
[options]="chart2Options"
[update]="updateFlag"
style="width: 100%; height: 400px; display: block;"
></highcharts-chart>
</mat-card-content>
</mat-card>
</div>

<div class="container" *ngIf="!seat">
Expand All @@ -55,62 +71,3 @@ <h2>{{ seat.assignee.login }}</h2>
<div class="spinner"></div>
</div>
</div>

<style>
.avatar {
border-radius: 50%;
margin-right: 8px;
vertical-align: middle;
}

.chart-controls {
display: flex;
justify-content: flex-end;
margin-bottom: 15px;
}

.loading-indicator {
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
height: 400px;
color: #666;
}

.spinner {
width: 40px;
height: 40px;
border: 4px solid rgba(0, 122, 204, 0.2);
border-top-color: #007ACC;
border-radius: 50%;
animation: spin 1s ease-in-out infinite;
margin: 20px 0;
}

@keyframes spin {
to { transform: rotate(360deg); }
}

.loading {
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
height: 300px;
font-size: 18px;
color: #666;
}

.additional-stats {
margin-top: 15px;
padding-top: 10px;
border-top: 1px solid #eee;
}

.additional-stats h3 {
margin-bottom: 8px;
color: #333;
font-size: 16px;
}
</style>
59 changes: 59 additions & 0 deletions frontend/src/app/main/copilot/copilot-seats/copilot-seat/copilot-seat.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,62 @@
font-size: 18px;
color: #666;
}



.avatar {
border-radius: 50%;
margin-right: 8px;
vertical-align: middle;
}

.chart-controls {
display: flex;
justify-content: flex-end;
margin-bottom: 15px;
}

.loading-indicator {
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
height: 400px;
color: #666;
}

.spinner {
width: 40px;
height: 40px;
border: 4px solid rgba(0, 122, 204, 0.2);
border-top-color: #007ACC;
border-radius: 50%;
animation: spin 1s ease-in-out infinite;
margin: 20px 0;
}

@keyframes spin {
to { transform: rotate(360deg); }
}

.loading {
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
height: 300px;
font-size: 18px;
color: #666;
}

.additional-stats {
margin-top: 15px;
padding-top: 10px;
border-top: 1px solid #eee;
}

.additional-stats h3 {
margin-bottom: 8px;
color: #333;
font-size: 16px;
}
156 changes: 75 additions & 81 deletions frontend/src/app/main/copilot/copilot-seats/copilot-seat/copilot-seat.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,40 @@ export class CopilotSeatComponent implements OnInit {
]
}
}
_chartOptions?: Highcharts.Options;
chart2Options: Highcharts.Options = {
title: {
text: "Seat Activity by Editor"
},
xAxis: {
type: "datetime"
},
legend: {
enabled: false
},
series: [
{
name: "Seat Activity",
type: "gantt",
data: []
}
],
plotOptions: {
gantt: {
borderWidth: 0,
borderColor: undefined,
dataLabels: {
enabled: true
}
}
},
tooltip: {},
yAxis: {
categories: [
"vscode",
"copilot-summarization-pr"
]
}
}
Comment on lines +75 to +108
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chart2Options initialization duplicates chartOptions with identical configuration (gantt type, same title, same structure). Since chart2Options is meant to display a scatter chart, this initialization should be updated to reflect scatter chart configuration or removed if the configuration will be completely replaced by the transformSeatActivityToScatter result.

Copilot uses AI. Check for mistakes.
id?: number | string;
seat?: Seat;
seatActivity?: Seat[];
Expand All @@ -91,29 +124,20 @@ export class CopilotSeatComponent implements OnInit {
) { }

ngOnInit() {
// Extract the seat ID from the URL route parameters
const id = this.activatedRoute.snapshot.paramMap.get('id');
if (!id) return; // Exit if no ID is found
if (!id) return;
this.id = id;

// Load the initial data with default timerange
this.loadData();
}

/**
* Loads seat activity data based on the selected time range
*/
loadData() {
if (!this.id) return;

// Show loading indicator - SET TO TRUE at the start of data loading
this.loading = true;
Copy link

Copilot AI Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of this.cdr.detectChanges() after setting this.loading = true may prevent the loading indicator from displaying immediately. Since the component uses ChangeDetectionStrategy.OnPush, manual change detection is needed to update the view. Consider keeping this call to ensure the loading state is reflected in the UI before the async operations begin.

Suggested change
this.loading = true;
this.loading = true;
this.cdr.detectChanges();

Copilot uses AI. Check for mistakes.
this.cdr.detectChanges();

let params: { since?: string; until?: string } = {};
const until = dayjs().toISOString();

// Set the since date based on the selected time range
switch (this.selectedTimeRange) {
case '7days':
params = { since: dayjs().subtract(7, 'day').toISOString(), until };
Expand All @@ -122,24 +146,17 @@ export class CopilotSeatComponent implements OnInit {
params = { since: dayjs().subtract(30, 'day').toISOString(), until };
break;
case 'all':
// Instead of empty params, use a far past date (e.g., 5 years ago)
// This ensures we don't send 'undefined' to the API
params = {
params = {
since: dayjs().subtract(5, 'year').toISOString(),
until
until
};
break;
}

// Create observables for all the data we need to fetch
const seatActivity$ = this.copilotSeatService.getSeat(this.id, params);

// First get the seat data to access the assignee login
seatActivity$.pipe(
this.copilotSeatService.getSeat(this.id, params).pipe(
map(seatData => {
// Store the complete seat activity data
this.seatActivity = seatData;

if (seatData.length > 0) {
this.seat = seatData[seatData.length - 1];
return this.seat?.assignee?.login;
Expand All @@ -151,81 +168,58 @@ export class CopilotSeatComponent implements OnInit {
return of(null);
})
).subscribe(login => {
// Now that we have the login, we can make the subsequent requests
if (!login) {
// Complete the process with default empty values if no login is available
this.loading = false;
this.cdr.detectChanges();
return;
}

// We now have the login, use it for survey queries
const surveyParams = {

this.surveyService.getAllSurveys({
since: params.since,
until: params.until,
userId: login
};

const surveys$ = this.surveyService.getAllSurveys(surveyParams).pipe(
}).pipe(
catchError(error => {
console.error('Error loading survey data:', error);
return of([] as Survey[]);
})
);

// Update forkJoin to only include surveys
forkJoin({
surveys: surveys$
}).subscribe({
next: (results) => {
// Process survey data - ensure surveys is an array
const surveysArray = Array.isArray(results.surveys) ? results.surveys : [results.surveys];
this.surveyCount = surveysArray.length;

if (this.surveyCount > 0) {
const totalTimeSavings = surveysArray.reduce((sum: number, survey: Survey) =>
sum + (survey.percentTimeSaved|| 0), 0);
const avgSavings = totalTimeSavings / this.surveyCount;
this.avgTimeSavings = avgSavings.toFixed(1) + '%';
}

// Transform the activity data into Highcharts Gantt chart format
// Use the full seatActivity array, not just the current seat
this._chartOptions = this.highchartsService.transformSeatActivityToGantt(this.seatActivity || []);

// Merge the transformed options with default chart options
this.chartOptions = {
...this.chartOptions,
...this._chartOptions
};

// Calculate total time spent based on Gantt data durations
this.timeSpent = " ~ " + Math.floor(dayjs.duration({
milliseconds: (this.chartOptions.series as Highcharts.SeriesGanttOptions[])?.reduce((total, series) => {
return total += series.data?.reduce((dataTotal, data) => dataTotal += (data.end || 0) - (data.start || 0), 0) || 0;
}, 0)
}).asHours()).toString() + " hrs"; // Formatted as hours

// Hide loading indicator - SET TO FALSE after successful data load
this.loading = false;

// Trigger chart update and refresh the component view
this.updateFlag = true;
this.cdr.detectChanges();
},
error: (error) => {
console.error('Error loading data:', error);
// Hide loading indicator - SET TO FALSE even if there's an error
this.loading = false;
this.cdr.detectChanges();
console.error('Error loading survey data:', error);
return of([] as Survey[]);
}),
).subscribe(surveys => {
const surveysArray = Array.isArray(surveys) ? surveys : [surveys];
this.surveyCount = surveysArray.length;

if (this.surveyCount > 0) {
const totalTimeSavings = surveysArray.reduce((sum: number, survey: Survey) =>
sum + (survey.percentTimeSaved || 0), 0);
const avgSavings = totalTimeSavings / this.surveyCount;
this.avgTimeSavings = avgSavings.toFixed(1) + '%';
}

this.chartOptions = {
...this.chartOptions,
...this.highchartsService.transformSeatActivityToGantt(this.seatActivity || [])
};

this.chart2Options = {
...this.chart2Options,
...this.highchartsService.transformSeatActivityToScatter(this.seatActivity || [])
};

this.timeSpent = " ~ " + Math.floor(dayjs.duration({
milliseconds: (this.chartOptions.series as Highcharts.SeriesGanttOptions[])?.reduce((total, series) => {
return total += series.data?.reduce((dataTotal, data) => dataTotal += (data.end || 0) - (data.start || 0), 0) || 0;
}, 0)
}).asHours()).toString() + " hrs"; // Formatted as hours

this.loading = false;

this.updateFlag = true;
this.cdr.detectChanges();
});
});
}

/**
* Handles time range selection change
*/
onTimeRangeChange() {
this.loadData();
}
Expand Down
Loading
Loading