chore: remove opencensus library #2558
Conversation
github-actions
bot
added
area/datastore
miparnisari
force-pushed
the
remove-opencensus
branch
from
1657647 to
572afde
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2558 +/- ##
==========================================
+ Coverage 77.70% 77.72% +0.03%
==========================================
Files 439 439
Lines 53526 53506 -20
==========================================
- Hits 41586 41584 -2
+ Misses 9351 9336 -15
+ Partials 2589 2586 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miparnisari
force-pushed
the
remove-opencensus
branch
from
572afde to
fd6188c
Compare
| flagSet.StringVar(&opts.SpannerEmulatorHost, flagName("datastore-spanner-emulator-host"), "", "URI of spanner emulator instance used for development and testing (e.g. localhost:9010)") | ||
| flagSet.Uint64Var(&opts.SpannerMinSessions, flagName("datastore-spanner-min-sessions"), 100, "minimum number of sessions across all Spanner gRPC connections the client can have at a given time") | ||
| flagSet.Uint64Var(&opts.SpannerMaxSessions, flagName("datastore-spanner-max-sessions"), 400, "maximum number of sessions across all Spanner gRPC connections the client can have at a given time") | ||
| flagSet.StringVar(&opts.SpannerDatastoreMetricsOption, flagName("datastore-spanner-metrics"), "otel", `configure the metrics that are emitted by the Spanner datastore ("none", "native", "otel", "deprecated-prometheus")`) |
There was a problem hiding this comment.
If someone is currently using this flag, is it a breaking change to remove it for them?
There was a problem hiding this comment.
Not a reason not to merge, but I want to make sure I understand that.
There was a problem hiding this comment.
Yes, it would. We should hide the flag and emit a warning if used
There was a problem hiding this comment.
to clarify: are y'all saying that i should keep deprecated-prometheus as an option here, and then if they pass that value, i say you are using a deprecated flag; will default to otel metrics?
There was a problem hiding this comment.
I think we should keep it for a few releases logging a warning and using otel instead. Then we can finally fully remove it.
|
I just noticed that #2329 is also open. |
Description
While working on https://github.com/authzed/spicedb/pull/2557/files#diff-0d9c5ed01c8a90734943ed1c028bda7f63b67ff60c564a042f69222e892ca962R41 noticed that this opencensus library was deprecated in 2023.
Also
DatastoreMetricsOptionLegacyPrometheuswas marked as deprecated in February of this year.So, killing two 🐦 with one 🪨 .
Testing
TODO test locally. Spin up Spanner and verify that metrics still flow
References