Skip to content

Conversation

@josephschorr
Copy link
Member

This should reduce memory usage a bit when reading the changes, as it can compute one-at-a-time

@josephschorr josephschorr requested a review from a team as a code owner September 25, 2025 22:07
@github-actions github-actions bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Sep 25, 2025
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 64.10256% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.68%. Comparing base (48ae087) to head (7fbb0b6).

Files with missing lines Patch % Lines
internal/datastore/mysql/watch.go 42.31% 13 Missing and 2 partials ⚠️
internal/datastore/memdb/memdb.go 47.06% 6 Missing and 3 partials ⚠️
internal/datastore/spanner/watch.go 0.00% 6 Missing ⚠️
internal/datastore/common/changes.go 92.16% 3 Missing and 1 partial ⚠️
internal/datastore/crdb/watch.go 60.00% 3 Missing and 1 partial ⚠️
internal/datastore/postgres/watch.go 42.86% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2578      +/-   ##
==========================================
- Coverage   77.71%   77.68%   -0.02%     
==========================================
  Files         441      441              
  Lines       54378    54391      +13     
==========================================
- Hits        42254    42249       -5     
- Misses       9505     9520      +15     
- Partials     2619     2622       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This should reduce memory usage a bit when reading the changes, as it can compute one-at-a-time
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Is there any reason not to do this? Is it worth benchmarking?

@josephschorr josephschorr added this pull request to the merge queue Sep 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 29, 2025
@josephschorr josephschorr added this pull request to the merge queue Sep 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants