Skip to content

Conversation

@powerslider
Copy link
Contributor

Why this should be merged

Check #4416

How this works

  • Introduce vms/evm/sync/message with request/response types:
    • BlockRequest/Response, LeafsRequest/Response, CodeRequest/Response.
  • Add Request and RequestHandler interfaces and wiring.
  • Add codec setup with versioning and max message size.
  • Add BlockSyncSummary and parser for sync bootstrap.
  • Add golden serialization tests and table-driven tests for handler dispatch and interface round-trips.

How this was tested

Existing and added UT in the package itself.

Need to be documented in RELEASES.md?

no

resolves #4416

Signed-off-by: Tsvetan Dimitrov ([email protected])

…`coreth`

- Introduce vms/evm/sync/message with request/response types:
 - BlockRequest/Response, LeafsRequest/Response, CodeRequest/Response.
- Add Request and RequestHandler interfaces and wiring.
- Add codec setup with versioning and max message size.
- Add BlockSyncSummary and parser for sync bootstrap.
- Add golden serialization tests and table-driven tests for handler dispatch and interface round-trips.

resolves #4416

Signed-off-by: Tsvetan Dimitrov ([email protected])
@joshua-kim joshua-kim moved this to Backlog 🧊 in avalanchego Oct 27, 2025
@powerslider powerslider force-pushed the powerslider/4416-migrate-message-coreth branch from 6ca3a38 to cd88b59 Compare October 30, 2025 17:42
…ality

- Consolidate related files: merge syncable.go, block_sync_summary_parser.go,
  block_sync_summary_provider.go into block_sync_summary.go and merge handler.go
  into request.go.
- Replace init() with lazy Codec() function using sync.Once.
- Add sentinel error for better error handling with require.ErrorIs.
- Convert tests to table-driven format and add comprehensive coverage.
- Improve documentation and fix linting issues.

BREAKING CHANGE: Codec initialization changed from init() to lazy
initialization via Codec() function.

resolves #4416

Signed-off-by: Tsvetan Dimitrov ([email protected])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog 🧊

Development

Successfully merging this pull request may close these issues.

Migrate message package from coreth

3 participants