-
Notifications
You must be signed in to change notification settings - Fork 820
chore(sync/message): migrate message package for EVM state sync from coreth
#4417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
powerslider
wants to merge
11
commits into
master
Choose a base branch
from
powerslider/4416-migrate-message-coreth
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,064
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`coreth` - Introduce vms/evm/sync/message with request/response types: - BlockRequest/Response, LeafsRequest/Response, CodeRequest/Response. - Add Request and RequestHandler interfaces and wiring. - Add codec setup with versioning and max message size. - Add BlockSyncSummary and parser for sync bootstrap. - Add golden serialization tests and table-driven tests for handler dispatch and interface round-trips. resolves #4416 Signed-off-by: Tsvetan Dimitrov ([email protected])
DracoLi
reviewed
Oct 14, 2025
DracoLi
approved these changes
Oct 17, 2025
6ca3a38 to
cd88b59
Compare
…ality - Consolidate related files: merge syncable.go, block_sync_summary_parser.go, block_sync_summary_provider.go into block_sync_summary.go and merge handler.go into request.go. - Replace init() with lazy Codec() function using sync.Once. - Add sentinel error for better error handling with require.ErrorIs. - Convert tests to table-driven format and add comprehensive coverage. - Improve documentation and fix linting issues. BREAKING CHANGE: Codec initialization changed from init() to lazy initialization via Codec() function. resolves #4416 Signed-off-by: Tsvetan Dimitrov ([email protected])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Check #4416
How this works
How this was tested
Existing and added UT in the package itself.
Need to be documented in RELEASES.md?
no
resolves #4416
Signed-off-by: Tsvetan Dimitrov ([email protected])