feat(node): Add CLI configuration validation for early error detection #795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds comprehensive CLI configuration validation that runs before node services start. This prevents invalid or dangerous configurations from causing runtime failures or consensus issues.
Key Changes
Added
Cli::validate()method that performs critical checks:grandpa_justification_periodandkate_max_cells_sizekate_max_cells_size(≤10,000) to prevent resource exhaustion--unsafe-da-sync+--validatorcombination (critical for consensus safety)Integrated validation into startup flow (
command.rs):Why This Matters
Previously, invalid configurations could: