Skip to content

Conversation

@michaelhtm
Copy link
Member

Issue #2731

Description of changes:
currently, we call DeletePolicy is not nil. This causes issues if the
value of the bucket policy is an empty string.
With these changes, we call DeletePolicy when the bucket policy is nil
or empty.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

currently, we call DeletePolicy is not nil. This causes issues if the
value of the bucket policy is an empty string.
With these changes, we call DeletePolicy when the bucket policy is nil
or empty.
@ack-prow ack-prow bot requested review from a-hilaly and knottnt December 31, 2025 18:37
@ack-prow
Copy link

ack-prow bot commented Dec 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Dec 31, 2025
@michaelhtm michaelhtm changed the title Fix/emptybucketpolicy call DeletePolicy if bucket policy is empty Dec 31, 2025
@michaelhtm michaelhtm force-pushed the fix/emptybucketpolicy branch from 35ca207 to 70dd1f0 Compare December 31, 2025 18:53
@michaelhtm michaelhtm force-pushed the fix/emptybucketpolicy branch 2 times, most recently from f21bb64 to 77bbf47 Compare December 31, 2025 19:34
@ack-prow
Copy link

ack-prow bot commented Dec 31, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
s3-verify-code-gen 77bbf47 link false /test s3-verify-code-gen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michaelhtm
Copy link
Member Author

/test s3-kind-e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant