Generate ListBucketAnalyticsConfiguration

[peterrsongg]

Description

4 of 5 stacked PRs. Generates ListBucketAnalyticsConfigurations
I will create one DevConfig with all these in merge PR.

Motivation and Context

Testing

Base-Branch dry run passed
FuzzTesting passed

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed

License

• I confirm that this pull request can be released under the Apache 2 license

[peterrsongg]

Breaking Changes Analysis Report

Summary

Analyzed 69 files changed in this PR migrating S3 Analytics and CreateSession operations from Custom to Generated code.

Total Breaking Changes Found: 5 files with issues

---

BREAKING CHANGES DETECTED

1. AnalyticsConfiguration.cs

File: sdk/src/Services/S3/Generated/Model/AnalyticsConfiguration.cs

ISSUE: Internal validation method logic changed

• Old Custom: return !(string.IsNullOrEmpty(this.analyticsId));
• New Generated: return this._analyticsId != null;
• Impact: The old code checked for both null AND empty strings, new code only checks for null. An empty string will now pass validation when it shouldn't.

---

2. AnalyticsExportDestination.cs

File: sdk/src/Services/S3/Generated/Model/AnalyticsExportDestination.cs

ISSUE: Added Required attribute to S3BucketDestination property

• Old Custom: No [AWSProperty(Required=true)] attribute
• New Generated: [AWSProperty(Required=true)] attribute added
• Impact: This property is now marked as required at the model level. This could cause validation errors for existing code that doesn't set this property.

---

3. AnalyticsS3BucketDestination.cs

File: sdk/src/Services/S3/Generated/Model/AnalyticsS3BucketDestination.cs

ISSUES (Multiple):

a) BucketName Required Attribute Added

• Old Custom: No [AWSProperty(Required=true)] attribute
• New Generated: [AWSProperty(Required=true)] attribute added
• Impact: BucketName is now required when previously it was optional

b) Format Required Attribute Added

• Old Custom: No [AWSProperty(Required=true)] attribute
• New Generated: [AWSProperty(Required=true)] attribute added
• Impact: Format is now required when previously it was optional

c) Internal Validation Methods Changed

• BucketAccountId:

  • Old: return !(string.IsNullOrEmpty(this.accountId));
  • New: return !String.IsNullOrEmpty(this._bucketAccountId);
  • Impact: Changed from checking both null and empty to using String.IsNullOrEmpty (functionally equivalent)

• BucketName:

  • Old: return !(string.IsNullOrEmpty(this.bucketName));
  • New: return !String.IsNullOrEmpty(this._bucketName);
  • Impact: Changed from checking both null and empty to using String.IsNullOrEmpty (functionally equivalent)

• Prefix:

  • Old: return !(string.IsNullOrEmpty(this.prefix));
  • New: return !String.IsNullOrEmpty(this._prefix);
  • Impact: Changed from checking both null and empty to using String.IsNullOrEmpty (functionally equivalent)

---

4. StorageClassAnalysisDataExport.cs

File: sdk/src/Services/S3/Generated/Model/StorageClassAnalysisDataExport.cs

ISSUES (Multiple):

a) Destination Required Attribute Added

• Old Custom: No [AWSProperty(Required=true)] attribute
• New Generated: [AWSProperty(Required=true)] attribute added
• Impact: Destination property is now required when previously it was optional

b) OutputSchemaVersion Required Attribute Added

• Old Custom: No [AWSProperty(Required=true)] attribute
• New Generated: [AWSProperty(Required=true)] attribute added
• Impact: OutputSchemaVersion is now required when previously it was optional

---

5. GetBucketAnalyticsConfigurationRequest.cs

File: sdk/src/Services/S3/Generated/Model/GetBucketAnalyticsConfigurationRequest.cs

ISSUES (Multiple):

a) AnalyticsId Required Attribute Added

• Old Custom: No [AWSProperty(Required=true)] attribute
• New Generated: [AWSProperty(Required=true)] attribute added
• Impact: AnalyticsId is now required when previously it was optional

b) BucketName Required Attribute Added

• Old Custom: No [AWSProperty(Required=true)] attribute
• New Generated: [AWSProperty(Required=true)] attribute added
• Impact: BucketName is now required when previously it was optional

c) Internal Validation Methods Changed

• AnalyticsId:

  • Old: return !(string.IsNullOrEmpty(this.analyticsId));
  • New: return this._analyticsId != null;
  • Impact: Old checked for both null AND empty strings, new only checks null. Empty string will now pass validation.

• BucketName:

  • Old: return !(string.IsNullOrEmpty(this.bucketName));
  • New: return this._bucketName != null;
  • Impact: Old checked for both null AND empty strings, new only checks null. Empty string will now pass validation.

---

VERIFIED AS CORRECT

The following changes were verified as correctly preserving existing behavior:

1. Custom Marshallers: Logic properly split between Generated and Custom files using partial methods:

   • GetBucketAnalyticsConfigurationRequestMarshaller - PreMarshallCustomization preserved
   • PutBucketAnalyticsConfigurationRequestMarshaller - AnalyticsFilterCustomMarshall and PostMarshallCustomization preserved
   • AnalyticsS3BucketDestinationUnmarshaller - FormatCustomUnmarshall preserved

2. SessionCredentials.cs - No breaking changes (identical behavior)

3. CreateSessionRequest.cs - No breaking changes (field name changes only, getters/setters identical)

4. StorageClassAnalysis.cs - No breaking changes (private field name change only)

---

Files Analyzed: 69/69 (100%)

Model Files Analyzed (16):

✅ AnalyticsConfiguration.cs ✅ AnalyticsExportDestination.cs
✅ AnalyticsS3BucketDestination.cs ✅ CreateSessionRequest.cs ✅ CreateSessionResponse.cs ✅ DeleteBucketAnalyticsConfigurationRequest.cs ✅ DeleteBucketAnalyticsConfigurationResponse.cs ✅ GetBucketAnalyticsConfigurationRequest.cs ✅ GetBucketAnalyticsConfigurationResponse.cs ✅ ListBucketAnalyticsConfigurationsRequest.cs ✅ ListBucketAnalyticsConfigurationsResponse.cs ✅ PutBucketAnalyticsConfigurationRequest.cs ✅ PutBucketAnalyticsConfigurationResponse.cs ✅ SessionCredentials.cs ✅ StorageClassAnalysis.cs ✅ StorageClassAnalysisDataExport.cs

Marshaller/Unmarshaller Files Analyzed (23):

✅ All marshaller and unmarshaller files verified for custom logic preservation

Configuration Files Analyzed (2):

✅ generator/ServiceClientGeneratorLib/ServiceModel.cs ✅ generator/ServiceModels/s3/s3.customizations.json

---

CRITICAL IMPACT SUMMARY

The most severe breaking changes are:

1. String validation changes that no longer reject empty strings (AnalyticsConfiguration, GetBucketAnalyticsConfigurationRequest)
2. Required attributes added to previously optional properties across multiple models, which will break existing code that doesn't set these properties

These changes violate backward compatibility and will cause runtime errors for existing customer code.

[dscpinheiro]

Approving but we should update the existing test to actually assert the response is expected...

aws-sdk-net/sdk/test/Services/S3/IntegrationTests/StorageInsightsAnalyticsTests.cs

Lines 264 to 272 in b6f0959

	private static void ListBucketAnalytics()
	{
	ListBucketAnalyticsConfigurationsRequest listBucketAnalyticsConfigurationsRequest = new ListBucketAnalyticsConfigurationsRequest()
	{
	BucketName = bucketName
	};
	var response = Client.ListBucketAnalyticsConfigurations(listBucketAnalyticsConfigurationsRequest);
	}