feat: adding instance-capacity-flex label to allow filter by flex instances #8315

rlanhellas · 2025-07-27T12:21:00Z

Description
Today we don't have a option to filter out all flex instances, instead we need to exclude one by one, which can be hard to maintain. This PR adds a new label karpenter.k8s.aws/instance-capacity-flex, which can have values true and/or false.

Example in NodePool:

        - key: karpenter.k8s.aws/instance-capacity-flex
          operator: In
          values: ["false"]

this will exclude all instances with -flex in the name.

How was this change tested?
On a real AWS EKS and added more tests cases.

Does this change impact docs?

Yes, PR includes docs updates
Yes, issue opened: #
No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…tance types Signed-off-by: Ronaldo Lanhellas <[email protected]>

netlify · 2025-07-27T12:21:05Z

✅ Deploy Preview for karpenter-docs-prod canceled.

Name	Link
🔨 Latest commit	`4bdbd0f`
🔍 Latest deploy log	https://app.netlify.com/projects/karpenter-docs-prod/deploys/68c052178ef139000896bb39

…tance types Signed-off-by: Ronaldo Lanhellas <[email protected]>

jmdeal

Only had a couple of few comments, looks good overall

pkg/providers/instancetype/suite_test.go

website/content/en/preview/concepts/nodepools.md

jmdeal

/karpenter snapshot

github-actions · 2025-08-19T16:13:45Z

Preview deployment ready!

Preview URL: https://pr-8315.d18coufmbnnaag.amplifyapp.com

Built from commit 4bdbd0f61d87c8b866544bd73c1deca396385099

coveralls · 2025-08-19T16:20:04Z

Pull Request Test Coverage Report for Build 17588838735

Details

7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.1%) to 67.248%

Files with Coverage Reduction	New Missed Lines	%
pkg/providers/instance/instance.go	1	91.96%

Totals
Change from base Build 17571686412:	0.1%
Covered Lines:	7636
Relevant Lines:	11355

💛 - Coveralls

github-actions · 2025-08-19T22:03:11Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-0f1617143dedd87bc9b84a92213329423034283b.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-0f1617143dedd87bc9b84a92213329423034283b" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Co-authored-by: Jason Deal <[email protected]>

Signed-off-by: Ronaldo Lanhellas <[email protected]>

jmdeal

/karpenter snapshot

github-actions · 2025-08-22T15:26:32Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-1d67ed0482464a04b1950fa316a10b322add1b85.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-1d67ed0482464a04b1950fa316a10b322add1b85" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jmdeal · 2025-08-25T21:34:24Z

Looks like there was a failure in the scheduling suite test, should just need to add an E2E test for flex instances here: https://github.com/aws/karpenter-provider-aws/blob/main/test/suites/scheduling/suite_test.go

rlanhellas · 2025-08-25T22:17:16Z

Looks like there was a failure in the scheduling suite test, should just need to add an E2E test for flex instances here: https://github.com/aws/karpenter-provider-aws/blob/main/test/suites/scheduling/suite_test.go

ok let me do it

Signed-off-by: Ronaldo Lanhellas <[email protected]>

rlanhellas · 2025-09-08T18:39:06Z

Looks like there was a failure in the scheduling suite test, should just need to add an E2E test for flex instances here: https://github.com/aws/karpenter-provider-aws/blob/main/test/suites/scheduling/suite_test.go

I added my tests, if you can run the pipe again

jmdeal

/karpenter snapshot

github-actions · 2025-09-08T18:44:37Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-784553d564cda8ab48bce2a449552fccd0db73dc.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-784553d564cda8ab48bce2a449552fccd0db73dc" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

jmdeal

/karpenter snapshot

github-actions · 2025-09-08T23:07:47Z

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-744ba5461d6dcded80397380c16f2c695ec6ece4.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-744ba5461d6dcded80397380c16f2c695ec6ece4" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

Signed-off-by: Ronaldo Lanhellas <[email protected]>

jmdeal

LGTM 🚀

feat: adding instance-capacity-flex label to allow filter by flex ins…

8edb7cc

…tance types Signed-off-by: Ronaldo Lanhellas <[email protected]>

rlanhellas requested a review from a team as a code owner July 27, 2025 12:21

rlanhellas requested a review from DerekFrank July 27, 2025 12:21

rlanhellas added 3 commits July 27, 2025 09:23

feat: adding instance-capacity-flex label to allow filter by flex ins…

aefa261

…tance types Signed-off-by: Ronaldo Lanhellas <[email protected]>

Merge branch 'main' into issue-4367

b44d242

Merge branch 'main' into issue-4367

0f16171

jmdeal self-assigned this Aug 18, 2025

jmdeal reviewed Aug 19, 2025

View reviewed changes

pkg/providers/instancetype/suite_test.go Outdated Show resolved Hide resolved

pkg/providers/instancetype/suite_test.go Outdated Show resolved Hide resolved

website/content/en/preview/concepts/nodepools.md Show resolved Hide resolved

jmdeal reviewed Aug 19, 2025

View reviewed changes

rlanhellas and others added 4 commits August 19, 2025 19:10

Update pkg/providers/instancetype/suite_test.go

7b7bd12

Co-authored-by: Jason Deal <[email protected]>

Update pkg/providers/instancetype/suite_test.go

d0f1641

Co-authored-by: Jason Deal <[email protected]>

Merge branch 'main' into issue-4367

789a5df

docs: update well-known labels

1d67ed0

Signed-off-by: Ronaldo Lanhellas <[email protected]>

jmdeal reviewed Aug 22, 2025

View reviewed changes

Merge branch 'main' into issue-4367

1ff61ce

rlanhellas added 2 commits August 30, 2025 19:51

Merge branch 'main' into issue-4367

feb101b

Merge branch 'main' into issue-4367

cc93c66

rlanhellas mentioned this pull request Sep 1, 2025

How does Karpenter deal with the new m7i-flex instance type? #4367

Closed

rlanhellas added 2 commits September 8, 2025 11:20

Merge branch 'main' into issue-4367

09b1f44

test: adding tests for flex instances

e26cdc8

Signed-off-by: Ronaldo Lanhellas <[email protected]>

rlanhellas force-pushed the issue-4367 branch from 9040a68 to e26cdc8 Compare September 8, 2025 18:22

Merge branch 'main' into issue-4367

784553d

jmdeal reviewed Sep 8, 2025

View reviewed changes

Merge branch 'main' into issue-4367

744ba54

jmdeal reviewed Sep 8, 2025

View reviewed changes

rlanhellas added 2 commits September 9, 2025 13:03

tests: adding exercise flex label

c08a9ff

Signed-off-by: Ronaldo Lanhellas <[email protected]>

tests: adding exercise flex label

346df48

Signed-off-by: Ronaldo Lanhellas <[email protected]>

jmdeal approved these changes Sep 9, 2025

View reviewed changes

jmdeal enabled auto-merge (squash) September 9, 2025 16:11

Merge branch 'main' into issue-4367

4bdbd0f

jmdeal merged commit c4fb150 into aws:main Sep 9, 2025
17 checks passed

jmdeal mentioned this pull request Sep 15, 2025

chore: rename flex label to instance-capability-flex #8490

Merged

3 tasks

feat: adding instance-capacity-flex label to allow filter by flex instances #8315

feat: adding instance-capacity-flex label to allow filter by flex instances #8315

Conversation

rlanhellas commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for karpenter-docs-prod canceled.

Uh oh!

jmdeal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmdeal left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 17588838735

Details

💛 - Coveralls

Uh oh!

github-actions bot commented Aug 19, 2025

Uh oh!

jmdeal left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 22, 2025

Uh oh!

jmdeal commented Aug 25, 2025

Uh oh!

rlanhellas commented Aug 25, 2025

Uh oh!

rlanhellas commented Sep 8, 2025

Uh oh!

jmdeal left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

jmdeal left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

jmdeal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rlanhellas commented Jul 27, 2025 •

edited

Loading

netlify bot commented Jul 27, 2025 •

edited

Loading

github-actions bot commented Aug 19, 2025 •

edited

Loading

coveralls commented Aug 19, 2025 •

edited

Loading