Skip to content

Conversation

@treyrichbourg
Copy link
Contributor

@treyrichbourg treyrichbourg commented Aug 22, 2025

Fixes #7081

Description
This PR removes HTTPProtocolIPv6 from default MetadataOptions for launch templates in unsupported regions.
Currently consumers are having to address this by using kubectl patch crd, creating a kustomization file, or other workarounds.
All affected regions addressed in this change.
#5700 (comment)

How was this change tested?

  • Added new test to amifamily suite.
  • All tests passing locally

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@treyrichbourg treyrichbourg requested a review from a team as a code owner August 22, 2025 04:35
@netlify
Copy link

netlify bot commented Aug 22, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit ad52ff6
🔍 Latest deploy log https://app.netlify.com/projects/karpenter-docs-prod/deploys/68a91c79b5d9e100086fa080

@treyrichbourg treyrichbourg force-pushed the main branch 2 times, most recently from a5e8dbb to 705ab7e Compare August 22, 2025 05:04
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2025

Preview deployment ready!

Preview URL: https://pr-8404.d18coufmbnnaag.amplifyapp.com

Built from commit ad52ff6846260c7c1e0407beabe7dd909e67d294

@coveralls
Copy link

coveralls commented Aug 23, 2025

Pull Request Test Coverage Report for Build 17169623627

Details

  • 17 of 18 (94.44%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 67.329%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/operator/operator.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 95.09%
Totals Coverage Status
Change from base Build 17162691683: 0.1%
Covered Lines: 7586
Relevant Lines: 11267

💛 - Coveralls

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal enabled auto-merge (squash) August 25, 2025 17:17
@jmdeal jmdeal merged commit 7db137a into aws:main Aug 25, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v0.32.7 Failing MetadataOptions for IPv6 in ISO regions

3 participants