Skip to content

Conversation

@ryan-mist
Copy link
Contributor

@ryan-mist ryan-mist commented Aug 24, 2025

Fixes #N/A

Description

  • Re-use existing successful CreateFleet calls to confirm that the EC2NodeClass is valid for launching nodes
    • i.e. when a successful CreateFleet call occurs, update the validation cache for the EC2NodeClass to allow next dry-run validation to be "skipped"

How was this change tested?

  • make presubmit
  • /karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Aug 24, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit b734f30
🔍 Latest deploy log https://app.netlify.com/projects/karpenter-docs-prod/deploys/68aa5889cde85700084c1b94

Copy link
Contributor Author

@ryan-mist ryan-mist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Preview deployment ready!

Preview URL: https://pr-8409.d18coufmbnnaag.amplifyapp.com

Built from commit b734f301ef1295631b997f834bc0887ef23df64f

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-b734f301ef1295631b997f834bc0887ef23df64f.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-b734f301ef1295631b997f834bc0887ef23df64f" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17181711532

Details

  • 62 of 80 (77.5%) changed or added relevant lines in 6 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 67.19%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/operator/operator.go 0 1 0.0%
pkg/controllers/nodeclass/validation.go 45 62 72.58%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/nodeclass/validation.go 1 84.84%
pkg/fake/utils.go 2 95.09%
pkg/fake/ec2api.go 7 85.42%
Totals Coverage Status
Change from base Build 17162691683: -0.01%
Covered Lines: 7571
Relevant Lines: 11268

💛 - Coveralls

@ryan-mist ryan-mist closed this Aug 29, 2025
@ryan-mist ryan-mist deleted the validation-cache branch August 30, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants