-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: remove iam:GetRole dependency #8419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for karpenter-docs-prod canceled.
|
56652c6 to
d27bef9
Compare
d27bef9 to
f528a81
Compare
|
Preview deployment ready! Preview URL: https://pr-8419.d18coufmbnnaag.amplifyapp.com Built from commit |
Pull Request Test Coverage Report for Build 17329251341Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/karpenter snapshot
|
Snapshot successfully published to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Fixes #N/A
Description
Drops the
iam:GetRoledependency in favor of caching the result fromiam:AddRoleToInstanceProfile. This isn't quite as airtight as theGetRolecheck since we'll still create an InstanceProfile each time the cache entry expires, so I've added a fail open attempt to delete the profile after a creation failure. If this does fail, we have the GC as a backstop.How was this change tested?
make presubmit&/karpenter snapshotDoes this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.