Skip to content

Conversation

@jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

Include K8s version 1.33 in testing for unit testing and E2E testing.

How was this change tested?

make presubmit
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Aug 28, 2025

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 1d0af7b
🔍 Latest deploy log https://app.netlify.com/projects/karpenter-docs-prod/deploys/68b1fd328056af0008f00983
😎 Deploy Preview https://deploy-preview-8426--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2025

Preview deployment ready!

Preview URL: https://pr-8426.d18coufmbnnaag.amplifyapp.com

Built from commit 1d0af7b645998f7d34d937d009ef851d6e41f3c5

@jonathan-innis jonathan-innis force-pushed the include-k8s-133 branch 4 times, most recently from 2c34121 to d6f5395 Compare August 28, 2025 17:59
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@jonathan-innis jonathan-innis force-pushed the include-k8s-133 branch 2 times, most recently from a82b8c2 to 5ed7700 Compare August 28, 2025 18:08
@github-actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-d6f53953ce13730c782c8f5a351d1808a19ea8ed.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-d6f53953ce13730c782c8f5a351d1808a19ea8ed" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@jonathan-innis jonathan-innis force-pushed the include-k8s-133 branch 18 times, most recently from 08a7068 to 8be1880 Compare August 29, 2025 06:47
@coveralls
Copy link

coveralls commented Aug 29, 2025

Pull Request Test Coverage Report for Build 17332421444

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • 19 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 67.193%

Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/al2.go 1 94.92%
pkg/fake/utils.go 2 95.09%
pkg/providers/amifamily/bootstrap/eksbootstrap.go 2 70.59%
pkg/providers/amifamily/bootstrap/bootstrap.go 14 68.42%
Totals Coverage Status
Change from base Build 17331439727: -0.1%
Covered Lines: 7617
Relevant Lines: 11336

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the include-k8s-133 branch 2 times, most recently from dd16d60 to 011b8cd Compare August 29, 2025 06:55
Copy link
Contributor Author

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-011b8cdf4adc6c7a89f52dc8727dc748746db20c.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-011b8cdf4adc6c7a89f52dc8727dc748746db20c" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@jonathan-innis jonathan-innis marked this pull request as ready for review August 29, 2025 15:31
@jonathan-innis jonathan-innis requested a review from a team as a code owner August 29, 2025 15:31
@jonathan-innis jonathan-innis requested a review from jmdeal August 29, 2025 15:31
@jonathan-innis jonathan-innis enabled auto-merge (squash) August 29, 2025 19:39
Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one nit

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit 33af907 into aws:main Aug 29, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants