Skip to content

Conversation

@saurav-agarwalla
Copy link
Contributor

@saurav-agarwalla saurav-agarwalla commented Aug 29, 2025

Fixes #N/A

Description

https://github.com/aws/karpenter-provider-aws/actions/runs/17331439806/job/49209511547 shows the build failing. Reproduced locally and saw that these files were getting updated.

How was this change tested?

make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@saurav-agarwalla saurav-agarwalla requested a review from a team as a code owner August 29, 2025 21:24
@netlify
Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit d064b5f
🔍 Latest deploy log https://app.netlify.com/projects/karpenter-docs-prod/deploys/68b21aab404b5d0008d63379

@github-actions
Copy link
Contributor

Preview deployment ready!

Preview URL: https://pr-8433.d18coufmbnnaag.amplifyapp.com

Built from commit d064b5f28bf94ae184aa9508d2f929b5b850ed3d

@coveralls
Copy link

coveralls commented Aug 29, 2025

Pull Request Test Coverage Report for Build 17335816984

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 67.217%

Files with Coverage Reduction New Missed Lines %
pkg/fake/iamapi.go 5 57.69%
pkg/providers/instanceprofile/instanceprofile.go 8 78.86%
Totals Coverage Status
Change from base Build 17335456280: -0.1%
Covered Lines: 7619
Relevant Lines: 11335

💛 - Coveralls

@saurav-agarwalla saurav-agarwalla enabled auto-merge (squash) August 29, 2025 21:46
@DerekFrank
Copy link
Contributor

Could we get more detail in the description?

@saurav-agarwalla
Copy link
Contributor Author

Could we get more detail in the description?

Done.

auto-merge was automatically disabled August 29, 2025 22:51

Pull request was closed

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) August 29, 2025 22:52
@jonathan-innis jonathan-innis merged commit bb55b36 into aws:main Aug 29, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants