Skip to content

Conversation

@jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Aug 29, 2025

Fixes #N/A

Description
Allow the role path to be conditionally disabled.

How was this change tested?
make test

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner August 29, 2025 22:04
@netlify
Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 69ac905
🔍 Latest deploy log https://app.netlify.com/projects/karpenter-docs-prod/deploys/68b2275b441d0900084d7e94

jonathan-innis
jonathan-innis previously approved these changes Aug 29, 2025
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal enabled auto-merge (squash) August 29, 2025 22:05
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

Preview deployment ready!

Preview URL: https://pr-8434.d18coufmbnnaag.amplifyapp.com

Built from commit 69ac90544da9778d0a826dfc4a78cb5924b799d0

@coveralls
Copy link

coveralls commented Aug 29, 2025

Pull Request Test Coverage Report for Build 17335388706

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 67.296%

Files with Coverage Reduction New Missed Lines %
pkg/fake/ec2api.go 3 84.79%
Totals Coverage Status
Change from base Build 17335191557: -0.02%
Covered Lines: 7628
Relevant Lines: 11335

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 83aa353 into aws:main Aug 29, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants