Skip to content

Conversation

@ryan-mist
Copy link
Contributor

Fixes #N/A

Description

  • remove additional pull commands from karpenter-crd and karpenter in the make release workflow (which pulls public ECR images just created by the workflow into a private ECR repo)

How was this change tested?

  • make presubmit

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ryan-mist ryan-mist marked this pull request as ready for review September 8, 2025 19:11
@ryan-mist ryan-mist requested a review from a team as a code owner September 8, 2025 19:11
@netlify
Copy link

netlify bot commented Sep 8, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 05dc934
🔍 Latest deploy log https://app.netlify.com/projects/karpenter-docs-prod/deploys/68bf2a3b8476f50008111cb9

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

Preview deployment ready!

Preview URL: https://pr-8468.d18coufmbnnaag.amplifyapp.com

Built from commit 05dc93416e0d13be61e7c42a5cdf1d374acbf841

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17561399252

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.228%

Totals Coverage Status
Change from base Build 17561158422: 0.0%
Covered Lines: 7629
Relevant Lines: 11348

💛 - Coveralls

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ryan-mist ryan-mist merged commit 6b03246 into aws:main Sep 9, 2025
18 checks passed
@ryan-mist ryan-mist deleted the mirror-public-ecr-fix branch September 12, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants