Skip to content

Conversation

@jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Sep 17, 2025

Fixes #N/A

Description

Bumps sigs.k8s.io/karpenter from 1.7.0 to 739062cc109f (diff)

Additionally, updates the GetDaemonSetOverhead expectation to use the new upstream helper package. This accounts for the fact that the ResourceRequestsForPod function no longer handles merging limits into requests since that's handled automatically by the API server for real pods.

How was this change tested?
make presubmit and /karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner September 17, 2025 20:50
@netlify
Copy link

netlify bot commented Sep 17, 2025

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit afd560b
🔍 Latest deploy log https://app.netlify.com/projects/karpenter-docs-prod/deploys/68cb285d9107ff0008b76cce

@jmdeal jmdeal added the blocked Unable to make progress due to some dependency label Sep 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2025

Preview deployment ready!

Preview URL: https://pr-8498.d18coufmbnnaag.amplifyapp.com

Built from commit afd560b6a45f17d0dd1e1145d7bce97107ce5796

Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@coveralls
Copy link

coveralls commented Sep 17, 2025

Pull Request Test Coverage Report for Build 17811199780

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 67.214%

Changes Missing Coverage Covered Lines Changed/Added Lines %
test/pkg/environment/common/expectations.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/providers/instance/instance.go 1 92.13%
Totals Coverage Status
Change from base Build 17758852518: -0.008%
Covered Lines: 7659
Relevant Lines: 11395

💛 - Coveralls

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-ae04f69e5a1b492d1859ec7266de468353a465d0.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-ae04f69e5a1b492d1859ec7266de468353a465d0" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@jmdeal
Copy link
Contributor Author

jmdeal commented Sep 17, 2025

Linking the snapshot run I started before I push to pin to the merged commit: https://github.com/aws/karpenter-provider-aws/actions/runs/17810433472

@jmdeal jmdeal force-pushed the feat/pod-level-resources branch from ae04f69 to afd560b Compare September 17, 2025 21:30
@jmdeal jmdeal removed the blocked Unable to make progress due to some dependency label Sep 17, 2025
Copy link
Contributor

@AndrewMitchell25 AndrewMitchell25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal enabled auto-merge (squash) September 17, 2025 21:36
@jmdeal jmdeal merged commit 3123abb into aws:main Sep 17, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants